mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-30 12:10:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

baseparse: Don't emit bitrate tags too early

Browse source 
We wait to parse a minimum number of frames (10, arbitrarily) before
emiting bitrate tags so that our early estimates are not wildly
inaccurate for streams that start with a silence. If the stream ends
before that, we just emit the tags anyway.

While it _would_ be nicer to be specify the threshold to start pushing
the tags in terms of duration, this would introduce more complexity than
this merits.

https://bugzilla.gnome.org/show_bug.cgi?id=614991
This commit is contained in:
Arun Raghavan 2010-03-26 18:56:49 +00:00 committed by Sebastian Dröge
parent 9b42d839e3
commit 90753ceb5e
1 changed files with 41 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
gst/audioparsers/gstbaseparse.c
View file

@ -190,6 +190,8 @@
#include "gstbaseparse.h" #include "gstbaseparse.h"
#define MIN_FRAMES_TO_POST_BITRATE 10
GST_DEBUG_CATEGORY_STATIC (gst_base_parse_debug); GST_DEBUG_CATEGORY_STATIC (gst_base_parse_debug);
#define GST_CAT_DEFAULT gst_base_parse_debug #define GST_CAT_DEFAULT gst_base_parse_debug
@ -312,6 +314,9 @@ gboolean gst_base_parse_convert (GstBaseParse * parse, GstFormat src_format,
static void gst_base_parse_drain (GstBaseParse * parse); static void gst_base_parse_drain (GstBaseParse * parse);
static void gst_base_parse_post_bitrates (GstBaseParse * parse,
gboolean post_min, gboolean post_avg, gboolean post_max);
static void static void
gst_base_parse_finalize (GObject * object) gst_base_parse_finalize (GObject * object)
{ {
@ -535,6 +540,11 @@ gst_base_parse_sink_event (GstPad * pad, GstEvent * event)
ret = TRUE; ret = TRUE;
} else { } else {
if (GST_EVENT_TYPE (event) == GST_EVENT_EOS &&
parse->priv->framecount < MIN_FRAMES_TO_POST_BITRATE)
/* We've not posted bitrate tags yet - do so now */
gst_base_parse_post_bitrates (parse, TRUE, TRUE, TRUE);
if (bclass->event) if (bclass->event)
handled = bclass->event (parse, event); handled = bclass->event (parse, event);
@ -855,6 +865,31 @@ gst_base_parse_update_duration (GstBaseParse * aacparse)
} }
} }
static void
gst_base_parse_post_bitrates (GstBaseParse * parse, gboolean post_min,
gboolean post_avg, gboolean post_max)
{
GstTagList *taglist = gst_tag_list_new ();
if (post_min && parse->priv->post_min_bitrate)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE,
GST_TAG_MINIMUM_BITRATE, parse->priv->min_bitrate, NULL);
if (post_avg && parse->priv->post_min_bitrate)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE, GST_TAG_BITRATE,
parse->priv->avg_bitrate, NULL);
if (post_max && parse->priv->post_max_bitrate)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE,
GST_TAG_MAXIMUM_BITRATE, parse->priv->max_bitrate, NULL);
GST_DEBUG_OBJECT (parse, "Updated bitrates. Min: %u, Avg: %u, Max: %u",
parse->priv->min_bitrate, parse->priv->avg_bitrate,
parse->priv->max_bitrate);
gst_element_found_tags_for_pad (GST_ELEMENT (parse), parse->srcpad, taglist);
}
/** /**
* gst_base_parse_update_bitrates: * gst_base_parse_update_bitrates:
* @parse: #GstBaseParse. * @parse: #GstBaseParse.
@ -906,38 +941,21 @@ gst_base_parse_update_bitrates (GstBaseParse * parse, GstBuffer * buffer)
if (frame_bitrate < parse->priv->min_bitrate) { if (frame_bitrate < parse->priv->min_bitrate) {
parse->priv->min_bitrate = frame_bitrate; parse->priv->min_bitrate = frame_bitrate;
update_min = parse->priv->post_min_bitrate; update_min = TRUE;
} }
if (frame_bitrate > parse->priv->max_bitrate) { if (frame_bitrate > parse->priv->max_bitrate) {
parse->priv->max_bitrate = frame_bitrate; parse->priv->max_bitrate = frame_bitrate;
update_max = parse->priv->post_max_bitrate; update_max = TRUE;
} }
if (old_avg_bitrate / update_threshold != if (old_avg_bitrate / update_threshold !=
parse->priv->avg_bitrate / update_threshold) parse->priv->avg_bitrate / update_threshold)
update_avg = parse->priv->post_avg_bitrate; update_avg = TRUE;
if (update_min || update_avg || update_max) { if (parse->priv->framecount >= MIN_FRAMES_TO_POST_BITRATE &&
GstTagList *taglist = gst_tag_list_new (); (update_min || update_avg || update_max))
gst_base_parse_post_bitrates (parse, update_min, update_avg, update_max);
if (update_min)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE, GST_TAG_MINIMUM_BITRATE,
parse->priv->min_bitrate, NULL);
if (update_avg)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE, GST_TAG_BITRATE,
parse->priv->avg_bitrate, NULL);
if (update_max)
gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE, GST_TAG_MAXIMUM_BITRATE,
parse->priv->max_bitrate, NULL);
GST_DEBUG_OBJECT (parse, "Updated bitrates. Min: %u, Avg: %u, Max: %u",
parse->priv->min_bitrate, parse->priv->avg_bitrate,
parse->priv->max_bitrate);
gst_element_found_tags_for_pad (GST_ELEMENT (parse), parse->srcpad,
taglist);
}
} }
/** /**