mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-14 03:15:47 +00:00
Code Issues 1 Projects Releases Wiki Activity

buffer: add more _is_writable checks

Browse source 
Add some checks to assert on writability for functions that modify metadata.
This commit is contained in:
Wim Taymans 2012-03-27 14:59:06 +02:00
parent 08f33d8d93
commit 8ff7a0978d
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/gstbuffer.c
View file

@ -1547,6 +1547,7 @@ gst_buffer_add_meta (GstBuffer * buffer, const GstMetaInfo * info,
g_return_val_if_fail (buffer != NULL, NULL); g_return_val_if_fail (buffer != NULL, NULL);
g_return_val_if_fail (info != NULL, NULL); g_return_val_if_fail (info != NULL, NULL);
g_return_val_if_fail (gst_buffer_is_writable (buffer), NULL);
/* create a new slice */ /* create a new slice */
size = ITEM_SIZE (info); size = ITEM_SIZE (info);
@ -1594,6 +1595,7 @@ gst_buffer_remove_meta (GstBuffer * buffer, GstMeta * meta)
g_return_val_if_fail (buffer != NULL, FALSE); g_return_val_if_fail (buffer != NULL, FALSE);
g_return_val_if_fail (meta != NULL, FALSE); g_return_val_if_fail (meta != NULL, FALSE);
g_return_val_if_fail (gst_buffer_is_writable (buffer), FALSE);
/* find the metadata and delete */ /* find the metadata and delete */
prev = GST_BUFFER_META (buffer); prev = GST_BUFFER_META (buffer);
@ -1692,6 +1694,8 @@ gst_buffer_foreach_meta (GstBuffer * buffer, GstBufferForeachMetaFunc func,
GST_CAT_DEBUG (GST_CAT_BUFFER, "remove metadata %p (%s)", m, GST_CAT_DEBUG (GST_CAT_BUFFER, "remove metadata %p (%s)", m,
g_type_name (info->type)); g_type_name (info->type));
g_return_if_fail (gst_buffer_is_writable (buffer));
/* remove from list */ /* remove from list */
if (GST_BUFFER_META (buffer) == walk) if (GST_BUFFER_META (buffer) == walk)
GST_BUFFER_META (buffer) = next; GST_BUFFER_META (buffer) = next;