mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

qtdemux: fix byte order swapping in 3GPP classification entity tag

Browse source 
Fixes #580746.
This commit is contained in:
Marco Ballesio 2009-04-29 15:58:10 +03:00 committed by René Stadler
parent 439ca2c795
commit 8e7273076d
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst/qtdemux/qtdemux.c
View file

@ -4492,12 +4492,12 @@ qtdemux_tag_add_classification (GstQTDemux * qtdemux, const char *tag,
{ {
int offset; int offset;
char *tag_str = NULL; char *tag_str = NULL;
guint32 entity; guint8 *entity;
guint16 table; guint16 table;
offset = 12; offset = 12;
entity = QT_FOURCC ((guint8 *) node->data + offset); entity = (guint8 *) node->data + offset;
offset += 4; offset += 4;
table = QT_UINT16 ((guint8 *) node->data + offset); table = QT_UINT16 ((guint8 *) node->data + offset);
@ -4510,8 +4510,11 @@ qtdemux_tag_add_classification (GstQTDemux * qtdemux, const char *tag,
* XXXX: classification entity, fixed length 4 chars. * XXXX: classification entity, fixed length 4 chars.
* Y[YYYY]: classification table, max 5 chars. * Y[YYYY]: classification table, max 5 chars.
*/ */
tag_str = g_strdup_printf ("%" GST_FOURCC_FORMAT "://%u/%s", tag_str = g_strdup_printf ("----://%u/%s",
GST_FOURCC_ARGS (entity), table, (char *) node->data + offset); table, (char *) node->data + offset);
/* memcpy To be sure we're preserving byte order */
memcpy (tag_str, entity, 4);
GST_DEBUG_OBJECT (qtdemux, "classification info: %s", tag_str); GST_DEBUG_OBJECT (qtdemux, "classification info: %s", tag_str);
gst_tag_list_add (qtdemux->tag_list, GST_TAG_MERGE_APPEND, tag, gst_tag_list_add (qtdemux->tag_list, GST_TAG_MERGE_APPEND, tag,