mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 14:06:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs/gst/base/gstbasesrc.c: Clarify FIXME comment in the face of having added unlock_stop()

Browse source 
Original commit message from CVS:
* libs/gst/base/gstbasesrc.c:
Clarify FIXME comment in the face of having added unlock_stop()
This commit is contained in:
Jan Schmidt 2007-03-21 17:50:46 +00:00
parent 9f3b0b8f3a
commit 8e36ce0940
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2007-03-21 Jan Schmidt <thaytan@mad.scientist.com>
* libs/gst/base/gstbasesrc.c:
Clarify FIXME comment in the face of having added unlock_stop()
2007-03-21 Wim Taymans <wim@fluendo.com>
* gst/gstbin.c: (gst_bin_get_type), (gst_bin_element_set_state):

9
libs/gst/base/gstbasesrc.c
View file

@ -851,9 +851,12 @@ gst_base_src_do_seek (GstBaseSrc * src, GstSegment * segment)
* when we reach the segment.stop we have to post a segment.done
* instead of EOS when doing a segment seek.
*/
/* FIXME, we have the unlock gboolean here because most current implementations
* (fdsrc, -base/gst/tcp/, ...) not only unlock when there is something to
* unlock
/* FIXME (0.11), we have the unlock gboolean here because most current
* implementations (fdsrc, -base/gst/tcp/, ...) unconditionally unlock, even when
* the streaming thread isn't running, resulting in bogus unlocks later when it
* starts. This is fixed by adding unlock_stop, but we should still avoid unlocking
* unnecessarily for backwards compatibility. Ergo, the unlock variable stays
* until 0.11
*/
static gboolean
gst_base_src_perform_seek (GstBaseSrc * src, GstEvent * event, gboolean unlock)