mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

shout2send: use version template in user-agent property

Browse source 
Avoids documentation churn when the version changes.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5090>
This commit is contained in:
Tim-Philipp Müller 2023-08-05 17:27:31 +01:00 committed by GStreamer Marge Bot
parent 5bbd8c2d71
commit 8d73b65789
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gst-plugins-good/docs/gst_plugins_cache.json
View file

@ -22187,7 +22187,7 @@
"construct": false, "construct": false,
"construct-only": false, "construct-only": false,
"controllable": false, "controllable": false,
"default": "GStreamer 1.23.0.1", "default": "GStreamer {VERSION}",
"mutable": "null", "mutable": "null",
"readable": true, "readable": true,
"type": "gchararray", "type": "gchararray",

15
subprojects/gst-plugins-good/ext/shout2/gstshout2.c
View file

@ -45,6 +45,8 @@
#include <glib/gi18n-lib.h> #include <glib/gi18n-lib.h>
#include <gst/glib-compat-private.h>
#ifndef HAVE_SHOUT_2_4_6_OR_NEWER #ifndef HAVE_SHOUT_2_4_6_OR_NEWER
#define shout_set_metadata_utf8 shout_set_metadata #define shout_set_metadata_utf8 shout_set_metadata
#endif #endif
@ -88,7 +90,7 @@ enum
#define DEFAULT_PUBLIC FALSE #define DEFAULT_PUBLIC FALSE
#define DEFAULT_STREAMNAME "" #define DEFAULT_STREAMNAME ""
#define DEFAULT_DESCRIPTION "" #define DEFAULT_DESCRIPTION ""
#define DEFAULT_USERAGENT "GStreamer " PACKAGE_VERSION #define DEFAULT_USERAGENT "GStreamer {VERSION}"
#define DEFAULT_GENRE "" #define DEFAULT_GENRE ""
#define DEFAULT_MOUNT "" #define DEFAULT_MOUNT ""
#define DEFAULT_URL "" #define DEFAULT_URL ""
@ -235,6 +237,9 @@ gst_shout2send_class_init (GstShout2sendClass * klass)
* *
* User agent of the source * User agent of the source
* *
* If the string contains `{VERSION}` that will be replaced with the
* GStreamer version at runtime (since GStreamer 1.24).
*
* Since: 1.22 * Since: 1.22
**/ **/
@ -574,10 +579,14 @@ gst_shout2send_start (GstBaseSink * basesink)
goto set_failed; goto set_failed;
cur_prop = "agent"; cur_prop = "agent";
GST_DEBUG_OBJECT (sink, "setting %s: %s", cur_prop, sink->user_agent); GString *user_agent = g_string_new (sink->user_agent);
if (shout_set_agent (sink->conn, sink->user_agent) != SHOUTERR_SUCCESS) { g_string_replace (user_agent, "{VERSION}", PACKAGE_VERSION, 0);
GST_DEBUG_OBJECT (sink, "setting %s: %s", cur_prop, user_agent->str);
if (shout_set_agent (sink->conn, user_agent->str) != SHOUTERR_SUCCESS) {
g_string_free (user_agent, TRUE);
goto set_failed; goto set_failed;
} }
g_string_free (user_agent, TRUE);
return TRUE; return TRUE;