mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin3: Prevent a critical warning when reassigning output slots

Browse source 
Do not attempt to send a streams-selected message when reassigning
an output slot in case upstream signalled that it is handling stream selection.
In this case decodebin3 doesn't keep track of stream
collections (`dbin->collection` is NULL).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5069>
This commit is contained in:
Philippe Normand 2023-07-18 15:15:40 +01:00 committed by GStreamer Marge Bot
parent eea9f74f95
commit 8d486d1398
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c
View file

@ -2218,6 +2218,11 @@ is_selection_done (GstDecodebin3 * dbin)
GST_LOG_OBJECT (dbin, "Checking"); GST_LOG_OBJECT (dbin, "Checking");
if (dbin->upstream_selected) {
GST_DEBUG ("Upstream handles stream selection, returning");
return NULL;
}
if (dbin->to_activate != NULL) { if (dbin->to_activate != NULL) {
GST_DEBUG ("Still have streams to activate"); GST_DEBUG ("Still have streams to activate");
return NULL; return NULL;