mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-01 21:18:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

ges-launcher: do not set rendering details too early

Browse source 
It looks like the _set_rendering_details call is superfluous
in _startup(), as it will get called in run_pipeline.

The problem with calling it before timeline_set_user_options
is that we are going to fail creating a smart profile if
the user selected eg --track-types=video, as the get_smart_profile
method compares the tracks in the asset with those on the timeline.

Reproduce with a video-only clip:

ges-launch-1.0 --track-types=video +clip file://$PWD/jelly.mp4 \
inpoint=15.0 -o foo.mp4 --smart-rendering

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/228>
This commit is contained in:
Mathieu Duponchelle 2021-01-29 20:42:26 +01:00
parent 60922c0288
commit 8bbd06c7c6
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tools/ges-launcher.c
View file

@ -1450,9 +1450,6 @@ _startup (GApplication * application)
if (!_set_playback_details (self))
goto failure;
if (!_set_rendering_details (self))
goto failure;
if (!_run_pipeline (self))
goto failure;