mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-18 07:47:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "qtdemux: fix conditions for end of segment in reverse playback"

Browse source 
This reverts commit 9deb3c27ac.

The test case that was described in the associated MR
(https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/262)
remains adequately fixed by a related MR that was merged later
(https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/275).

It introduced incorrect logic that broke edit lists as described in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2549

Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2549
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4605>
This commit is contained in:
Mathieu Duponchelle 2023-05-05 19:41:34 +02:00 committed by Tim-Philipp Müller
parent 850c57bad7
commit 8bb2d23666
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
View file

@ -6547,16 +6547,8 @@ gst_qtdemux_loop_state_movie (GstQTDemux * qtdemux)
stream = QTDEMUX_NTH_STREAM (qtdemux, i);
position = stream->time_position;
if (!GST_CLOCK_TIME_IS_VALID (position))
continue;
if (stream->segment_index != -1) {
QtDemuxSegment *segment = &stream->segments[stream->segment_index];
position += segment->media_start;
}
/* position of -1 is EOS */
if (position < min_time) {
if (position != GST_CLOCK_TIME_NONE && position < min_time) {
min_time = position;
target_stream = stream;
}