mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 15:27:07 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstvalue: Prevent division or modulo by zero

Browse source 
The step can end up being zero if the underlying value isn't a valid
range GValue.

In those cases, return FALSE.

We don't use g_return*_if_fail since it will already have been triggered
by the above-mentionned _get_step() functions.

CID #1037132
This commit is contained in:
Edward Hervey 2014-04-05 11:37:53 +02:00 committed by Edward Hervey
parent 3e24bbefba
commit 8b51e9dc60
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/gstvalue.c
View file

@ -4445,6 +4445,8 @@ gst_value_list_equals_range (const GValue * list, const GValue * value)
const gint64 rmax = gst_value_get_int64_range_max (value); const gint64 rmax = gst_value_get_int64_range_max (value);
const gint64 rstep = gst_value_get_int64_range_step (value); const gint64 rstep = gst_value_get_int64_range_step (value);
GST_DEBUG ("List/range of int64s"); GST_DEBUG ("List/range of int64s");
if (rstep == 0)
return FALSE;
if (list_size != rmax / rstep - rmin / rstep + 1) if (list_size != rmax / rstep - rmin / rstep + 1)
return FALSE; return FALSE;
for (n = 0; n < list_size; ++n) { for (n = 0; n < list_size; ++n) {