rtspsrc: Don't return TRUE for unhandled query

Expected return value for unhandled query is FALSE

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/629>
This commit is contained in:
Seungha Yang 2020-06-16 19:34:01 +09:00
parent 536ff4776f
commit 8b4f18d53b

View file

@ -3057,7 +3057,7 @@ gst_rtspsrc_handle_internal_src_query (GstPad * pad, GstObject * parent,
GstQuery * query) GstQuery * query)
{ {
GstRTSPSrc *src; GstRTSPSrc *src;
gboolean res = TRUE; gboolean res = FALSE;
src = GST_RTSPSRC_CAST (gst_pad_get_element_private (pad)); src = GST_RTSPSRC_CAST (gst_pad_get_element_private (pad));
@ -3079,9 +3079,9 @@ gst_rtspsrc_handle_internal_src_query (GstPad * pad, GstObject * parent,
switch (format) { switch (format) {
case GST_FORMAT_TIME: case GST_FORMAT_TIME:
gst_query_set_duration (query, format, src->segment.duration); gst_query_set_duration (query, format, src->segment.duration);
res = TRUE;
break; break;
default: default:
res = FALSE;
break; break;
} }
break; break;
@ -3091,6 +3091,7 @@ gst_rtspsrc_handle_internal_src_query (GstPad * pad, GstObject * parent,
/* we are live with a min latency of 0 and unlimited max latency, this /* we are live with a min latency of 0 and unlimited max latency, this
* result will be updated by the session manager if there is any. */ * result will be updated by the session manager if there is any. */
gst_query_set_latency (query, src->is_live, 0, -1); gst_query_set_latency (query, src->is_live, 0, -1);
res = TRUE;
break; break;
} }
default: default: