mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

flactag: Fix possible NULL pointer dereference

Browse source
This commit is contained in:
Sebastian Dröge 2010-06-16 19:28:04 +02:00
parent 711e0cc90b
commit 8b2a6a8c74
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/flac/gstflactag.c
View file

@ -364,6 +364,8 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
if (buffer == NULL) { if (buffer == NULL) {
GST_ELEMENT_ERROR (tag, CORE, TOO_LAZY, (NULL), GST_ELEMENT_ERROR (tag, CORE, TOO_LAZY, (NULL),
("Error creating 12-byte buffer for padding block")); ("Error creating 12-byte buffer for padding block"));
ret = GST_FLOW_ERROR;
goto cleanup;
} }
memset (GST_BUFFER_DATA (buffer), 0, GST_BUFFER_SIZE (buffer)); memset (GST_BUFFER_DATA (buffer), 0, GST_BUFFER_SIZE (buffer));
GST_BUFFER_DATA (buffer)[0] = 0x81; /* 0x80 = Last metadata block, GST_BUFFER_DATA (buffer)[0] = 0x81; /* 0x80 = Last metadata block,
@ -383,6 +385,7 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
if (buffer == NULL) { if (buffer == NULL) {
GST_ELEMENT_ERROR (tag, CORE, TAG, (NULL), GST_ELEMENT_ERROR (tag, CORE, TAG, (NULL),
("Error converting tag list to vorbiscomment buffer")); ("Error converting tag list to vorbiscomment buffer"));
ret = GST_FLOW_ERROR;
goto cleanup; goto cleanup;
} }
size = GST_BUFFER_SIZE (buffer) - 4; size = GST_BUFFER_SIZE (buffer) - 4;
@ -393,6 +396,7 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
*/ */
GST_ELEMENT_ERROR (tag, CORE, TAG, (NULL), GST_ELEMENT_ERROR (tag, CORE, TAG, (NULL),
("Vorbis comment of size %d too long", size)); ("Vorbis comment of size %d too long", size));
ret = GST_FLOW_ERROR;
goto cleanup; goto cleanup;
} }