glimagesink: Call gst_object_unref() on the GstGL GObjects again

While they're plain GObjects it does not hurt to call gst_object_unref()
on them and potentially allows to debug reference leaks a bit easier.
This commit is contained in:
Sebastian Dröge 2014-04-23 10:24:55 +02:00
parent 38ebfb2da8
commit 89d2bb75d6

View file

@ -423,7 +423,7 @@ _ensure_gl_setup (GstGLImageSink * gl_sink)
if (!gst_gl_context_create (gl_sink->context, gl_sink->other_context, if (!gst_gl_context_create (gl_sink->context, gl_sink->other_context,
&error)) { &error)) {
g_object_unref (window); gst_object_unref (window);
goto context_error; goto context_error;
} }
@ -438,7 +438,7 @@ _ensure_gl_setup (GstGLImageSink * gl_sink)
GST_GL_WINDOW_CB (gst_glimage_sink_on_close), GST_GL_WINDOW_CB (gst_glimage_sink_on_close),
gst_object_ref (gl_sink), (GDestroyNotify) gst_object_unref); gst_object_ref (gl_sink), (GDestroyNotify) gst_object_unref);
g_object_unref (window); gst_object_unref (window);
} }
if (!gl_sink->upload) { if (!gl_sink->upload) {
@ -453,7 +453,7 @@ upload_error:
{ {
GST_ELEMENT_ERROR (gl_sink, RESOURCE, NOT_FOUND, ("Failed to init upload"), GST_ELEMENT_ERROR (gl_sink, RESOURCE, NOT_FOUND, ("Failed to init upload"),
(NULL)); (NULL));
g_object_unref (gl_sink->upload); gst_object_unref (gl_sink->upload);
gl_sink->upload = NULL; gl_sink->upload = NULL;
return FALSE; return FALSE;
} }
@ -461,7 +461,7 @@ context_error:
{ {
GST_ELEMENT_ERROR (gl_sink, RESOURCE, NOT_FOUND, ("%s", error->message), GST_ELEMENT_ERROR (gl_sink, RESOURCE, NOT_FOUND, ("%s", error->message),
(NULL)); (NULL));
g_object_unref (gl_sink->context); gst_object_unref (gl_sink->context);
gl_sink->context = NULL; gl_sink->context = NULL;
return FALSE; return FALSE;
} }