mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-03 04:52:28 +00:00
Code Issues 1 Projects Releases Wiki Activity

h263parse: Fix PSC matching

Browse source 
We were off by one byte in the matching

It should be (using 24 bit matching):
   * startcode  : 0000 0000 0000 0000 1000 00xx
   * mask (bin) : 1111 1111 1111 1111 1111 1100
   * mask (hex) :    f    f    f    f    f    c
   * match      :    0    0    0    0    8    0

https://bugzilla.gnome.org/show_bug.cgi?id=750685
This commit is contained in:
Edward Hervey 2015-06-10 10:36:21 +02:00 committed by Edward Hervey
parent 29c79d7595
commit 898b436219
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/videoparsers/gsth263parse.c
View file

@ -169,10 +169,15 @@ find_psc (GstBuffer * buffer, guint skip)
if (gst_byte_reader_peek_uint24_be (&br, &psc) == FALSE) if (gst_byte_reader_peek_uint24_be (&br, &psc) == FALSE)
goto out; goto out;
/* Scan for the picture start code (22 bits - 0x0020) */ /* Scan for the picture start code (22 bits - 0x0020)
* startcode : 0000 0000 0000 0000 1000 00xx
* mask (bin) : 1111 1111 1111 1111 1111 1100
* mask (hex) : f f f f f c
* match : 0 0 0 0 8 0
*/
while ((gst_byte_reader_get_remaining (&br) >= 3)) { while ((gst_byte_reader_get_remaining (&br) >= 3)) {
if (gst_byte_reader_peek_uint24_be (&br, &psc) && if (gst_byte_reader_peek_uint24_be (&br, &psc) &&
((psc & 0xffffc0) == 0x000080)) { ((psc & 0xfffffc) == 0x000080)) {
psc_pos = gst_byte_reader_get_pos (&br); psc_pos = gst_byte_reader_get_pos (&br);
break; break;
} else if (gst_byte_reader_skip (&br, 1) == FALSE) } else if (gst_byte_reader_skip (&br, 1) == FALSE)