mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-09-09 05:38:58 +00:00
v4l2codecs: h264dec: Remove outdated comment
... and unnecessary user data clear on GstVideoCodecFrame Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1457>
This commit is contained in:
parent
96b9000289
commit
87b150c42a
1 changed files with 0 additions and 14 deletions
|
@ -889,20 +889,6 @@ finish_frame:
|
||||||
if (self->copy_frames)
|
if (self->copy_frames)
|
||||||
gst_v4l2_codec_h264_dec_copy_output_buffer (self, frame);
|
gst_v4l2_codec_h264_dec_copy_output_buffer (self, frame);
|
||||||
|
|
||||||
/* At this point, GstVideoCodecFrame holds
|
|
||||||
* - GstBuffer (GstVideoCodecFrame::output_buffer)
|
|
||||||
* - GstH264Picture and GstH264Picture holds GstBuffer as well.
|
|
||||||
* So the refcount of the output buffer would be at least 2 here
|
|
||||||
* if the given GstH264Picture is the last reference.
|
|
||||||
*
|
|
||||||
* To make a chance that only this GstVideoCodecFrame holds the reference
|
|
||||||
* of the GstBuffer, clear user data of GstVideoCodecFrame
|
|
||||||
* (i.e., drop the reference of GstH264Picture).
|
|
||||||
* Otherwise, if the reference count of the GstBuffer is not one,
|
|
||||||
* the buffer will be copied always
|
|
||||||
* by gst_buffer_make_writable() in gst_video_decoder_finish_frame()
|
|
||||||
*/
|
|
||||||
gst_video_codec_frame_set_user_data (frame, NULL, NULL);
|
|
||||||
gst_h264_picture_unref (picture);
|
gst_h264_picture_unref (picture);
|
||||||
|
|
||||||
return gst_video_decoder_finish_frame (vdec, frame);
|
return gst_video_decoder_finish_frame (vdec, frame);
|
||||||
|
|
Loading…
Reference in a new issue