mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-25 01:54:17 +00:00
Code Issues1 Projects Releases Wiki Activity

v4l2codecs: h264dec: Remove outdated comment

Browse source 
... and unnecessary user data clear on GstVideoCodecFrame

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1457>
This commit is contained in:
Seungha Yang 2020-07-23 18:03:23 +09:00
parent 96b9000289
commit 87b150c42a
1 changed files with 0 additions and 14 deletions

14
sys/v4l2codecs/gstv4l2codech264dec.c
View file

@ -889,20 +889,6 @@ finish_frame:
if (self->copy_frames)
gst_v4l2_codec_h264_dec_copy_output_buffer (self, frame);
/* At this point, GstVideoCodecFrame holds
* - GstBuffer (GstVideoCodecFrame::output_buffer)
* - GstH264Picture and GstH264Picture holds GstBuffer as well.
* So the refcount of the output buffer would be at least 2 here
* if the given GstH264Picture is the last reference.
*
* To make a chance that only this GstVideoCodecFrame holds the reference
* of the GstBuffer, clear user data of GstVideoCodecFrame
* (i.e., drop the reference of GstH264Picture).
* Otherwise, if the reference count of the GstBuffer is not one,
* the buffer will be copied always
* by gst_buffer_make_writable() in gst_video_decoder_finish_frame()
*/
gst_video_codec_frame_set_user_data (frame, NULL, NULL);
gst_h264_picture_unref (picture);
return gst_video_decoder_finish_frame (vdec, frame);