mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 22:36:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstav1parse: fixup various possible logical errors

Browse source 
Found via an analyzed build for Clang. Specifically we had:

gstav1parse.c[1850,11] in gst_av1_parse_detect_stream_format: Logic error: The left operand of '==' is a garbage value
gstav1parse.c[1606,11] in gst_av1_parse_handle_to_small_and_equal_align: Logic error: The left operand of '==' is a garbage value

Also a couple of false-positives:

gstav1parse.c[1398,24] in gst_av1_parse_handle_one_obu: Logic error: Branch condition evaluates to a garbage value
gstav1parse.c[1440,37] in gst_av1_parse_handle_one_obu: Logic error: The left operand of '-' is a garbage value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2230>
This commit is contained in:
Camilo Celis Guzman 2022-04-18 17:50:22 +09:00 committed by GStreamer Marge Bot
parent e950095867
commit 8707d0cb26
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c
View file

@ -1558,7 +1558,7 @@ gst_av1_parse_handle_to_small_and_equal_align (GstBaseParse * parse,
GstMapInfo map_info; GstMapInfo map_info;
GstAV1OBU obu; GstAV1OBU obu;
GstFlowReturn ret = GST_FLOW_OK; GstFlowReturn ret = GST_FLOW_OK;
GstAV1ParserResult res; GstAV1ParserResult res = GST_AV1_PARSER_INVALID_OPERATION;
GstBuffer *buffer = gst_buffer_ref (frame->buffer); GstBuffer *buffer = gst_buffer_ref (frame->buffer);
guint32 total_consumed, consumed; guint32 total_consumed, consumed;
gboolean frame_complete; gboolean frame_complete;
@ -1789,7 +1789,7 @@ gst_av1_parse_detect_stream_format (GstBaseParse * parse,
GstAV1Parse *self = GST_AV1_PARSE (parse); GstAV1Parse *self = GST_AV1_PARSE (parse);
GstMapInfo map_info; GstMapInfo map_info;
GstAV1OBU obu; GstAV1OBU obu;
GstAV1ParserResult res; GstAV1ParserResult res = GST_AV1_PARSER_INVALID_OPERATION;
GstBuffer *buffer = gst_buffer_ref (frame->buffer); GstBuffer *buffer = gst_buffer_ref (frame->buffer);
gboolean got_seq, got_frame; gboolean got_seq, got_frame;
gboolean frame_complete; gboolean frame_complete;