mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

gl/contextglx: error out on more invalid display/window combinations

Browse source 
https://bugzilla.gnome.org/show_bug.cgi?id=774851
This commit is contained in:
Matthew Waters 2016-11-23 17:04:34 +11:00 committed by Tim-Philipp Müller
parent afbca8576e
commit 86a9499d5e
1 changed files with 30 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
gst-libs/gst/gl/x11/gstglcontext_glx.c
View file

@ -194,7 +194,7 @@ gst_gl_context_glx_create_context (GstGLContext * context,
GstGLContextGLX *context_glx; GstGLContextGLX *context_glx;
GstGLWindow *window; GstGLWindow *window;
GstGLWindowX11 *window_x11; GstGLWindowX11 *window_x11;
GstGLDisplay *display; GstGLDisplay *display = NULL;
gboolean create_context; gboolean create_context;
const char *glx_exts; const char *glx_exts;
Display *device; Display *device;
@ -202,6 +202,14 @@ gst_gl_context_glx_create_context (GstGLContext * context,
context_glx = GST_GL_CONTEXT_GLX (context); context_glx = GST_GL_CONTEXT_GLX (context);
window = gst_gl_context_get_window (context); window = gst_gl_context_get_window (context);
if (!GST_IS_GL_WINDOW_X11 (window)) {
g_set_error (error, GST_GL_CONTEXT_ERROR,
GST_GL_CONTEXT_ERROR_WRONG_CONFIG,
"Cannot create an GLX context from a non-X11 window");
goto failure;
}
window_x11 = GST_GL_WINDOW_X11 (window); window_x11 = GST_GL_WINDOW_X11 (window);
display = gst_gl_context_get_display (context); display = gst_gl_context_get_display (context);
@ -217,6 +225,12 @@ gst_gl_context_glx_create_context (GstGLContext * context,
} }
device = (Display *) gst_gl_display_get_handle (display); device = (Display *) gst_gl_display_get_handle (display);
if (!device) {
g_set_error (error, GST_GL_CONTEXT_ERROR,
GST_GL_CONTEXT_ERROR_RESOURCE_UNAVAILABLE, "Invalid Display handle");
goto failure;
}
glx_exts = glXQueryExtensionsString (device, DefaultScreen (device)); glx_exts = glXQueryExtensionsString (device, DefaultScreen (device));
create_context = gst_gl_check_extension ("GLX_ARB_create_context", glx_exts); create_context = gst_gl_check_extension ("GLX_ARB_create_context", glx_exts);
@ -281,7 +295,8 @@ gst_gl_context_glx_create_context (GstGLContext * context,
failure: failure:
if (window) if (window)
gst_object_unref (window); gst_object_unref (window);
gst_object_unref (display); if (display)
gst_object_unref (display);
return FALSE; return FALSE;
} }
@ -316,8 +331,21 @@ gst_gl_context_glx_choose_format (GstGLContext * context, GError ** error)
context_glx = GST_GL_CONTEXT_GLX (context); context_glx = GST_GL_CONTEXT_GLX (context);
window = gst_gl_context_get_window (context); window = gst_gl_context_get_window (context);
if (!GST_IS_GL_WINDOW_X11 (window)) {
g_set_error (error, GST_GL_CONTEXT_ERROR,
GST_GL_CONTEXT_ERROR_WRONG_CONFIG,
"Cannot create an GLX context from a non-X11 window");
goto failure;
}
window_x11 = GST_GL_WINDOW_X11 (window); window_x11 = GST_GL_WINDOW_X11 (window);
device = (Display *) gst_gl_display_get_handle (window->display); device = (Display *) gst_gl_display_get_handle (window->display);
if (!device) {
g_set_error (error, GST_GL_CONTEXT_ERROR,
GST_GL_CONTEXT_ERROR_RESOURCE_UNAVAILABLE, "Invalid Display handle");
goto failure;
}
if (!glXQueryExtension (device, &error_base, &event_base)) { if (!glXQueryExtension (device, &error_base, &event_base)) {
g_set_error (error, GST_GL_CONTEXT_ERROR, g_set_error (error, GST_GL_CONTEXT_ERROR,