mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-02 21:48:55 +00:00
Code Issues 1 Projects Releases Wiki Activity

multifilesink: close file on write error with next-file mode is set to buffer

Browse source 
If we have an error during fwrite call, file stays open and thus next
incoming buffer will trigger an assert when trying to opening a new
file.
This happens if we do not restart element, file is closed at stop, and
if application handles the returned GST_FLOW_ERROR to keep bin alive.

https://bugzilla.gnome.org/show_bug.cgi?id=762434
This commit is contained in:
Aurélien Zanelli 2016-02-22 11:01:40 +01:00 committed by Sebastian Dröge
parent 8657987f8f
commit 84e441d268
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/multifile/gstmultifilesink.c
View file

@ -627,8 +627,10 @@ gst_multi_file_sink_write_buffer (GstMultiFileSink * multifilesink,
"Writing buffer data (%" G_GSIZE_FORMAT " bytes) to new file", "Writing buffer data (%" G_GSIZE_FORMAT " bytes) to new file",
map.size); map.size);
ret = fwrite (map.data, map.size, 1, multifilesink->file); ret = fwrite (map.data, map.size, 1, multifilesink->file);
if (ret != 1) if (ret != 1) {
gst_multi_file_sink_close_file (multifilesink, NULL);
goto stdio_write_error; goto stdio_write_error;
}
gst_multi_file_sink_close_file (multifilesink, buffer); gst_multi_file_sink_close_file (multifilesink, buffer);
break; break;