mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 07:28:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

jpegdec: Check return value of gst_buffer_map()

Browse source 
Without this check, the element will crash instead of returning an
error.
This commit is contained in:
Nicolas Dufresne 2020-01-27 17:16:02 -05:00 committed by GStreamer Merge Bot
parent eb0b676fae
commit 83e9d4f70d
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ext/jpeg/gstjpegdec.c
View file

@ -1204,7 +1204,9 @@ gst_jpeg_dec_handle_frame (GstVideoDecoder * bdec, GstVideoCodecFrame * frame)
guint8 *data; guint8 *data;
gsize nbytes; gsize nbytes;
gst_buffer_map (frame->input_buffer, &dec->current_frame_map, GST_MAP_READ); if (!gst_buffer_map (frame->input_buffer, &dec->current_frame_map,
GST_MAP_READ))
goto map_failed;
data = dec->current_frame_map.data; data = dec->current_frame_map.data;
nbytes = dec->current_frame_map.size; nbytes = dec->current_frame_map.size;
@ -1393,6 +1395,13 @@ need_more_data:
goto exit; goto exit;
} }
/* ERRORS */ /* ERRORS */
map_failed:
{
GST_ELEMENT_ERROR (dec, RESOURCE, READ, (_("Failed to read memory")),
("gst_buffer_map() failed for READ access"));
ret = GST_FLOW_ERROR;
goto exit;
}
decode_error: decode_error:
{ {
gchar err_msg[JMSG_LENGTH_MAX]; gchar err_msg[JMSG_LENGTH_MAX];