mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 06:46:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

tagdemux: add FIXME

Browse source 
Add a FIXME because the EOS before-type case now has to be solved differently
because the srcpad is always available.
This commit is contained in:
Wim Taymans 2011-12-19 11:03:55 +01:00
parent 6b702c60bb
commit 81d351b5f0
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst-libs/gst/tag/gsttagdemux.c
View file

@ -646,11 +646,6 @@ gst_tag_demux_chain (GstPad * pad, GstObject * parent, GstBuffer * buf)
return GST_FLOW_EOS; return GST_FLOW_EOS;
} }
if (outbuf) { if (outbuf) {
if (G_UNLIKELY (demux->priv->srcpad == NULL)) {
gst_buffer_unref (outbuf);
return GST_FLOW_ERROR;
}
/* Might need a new segment before the buffer */ /* Might need a new segment before the buffer */
if (demux->priv->need_newseg) { if (demux->priv->need_newseg) {
if (!gst_tag_demux_send_new_segment (demux)) { if (!gst_tag_demux_send_new_segment (demux)) {
@ -688,6 +683,7 @@ gst_tag_demux_sink_event (GstPad * pad, GstObject * parent, GstEvent * event)
switch (GST_EVENT_TYPE (event)) { switch (GST_EVENT_TYPE (event)) {
case GST_EVENT_EOS: case GST_EVENT_EOS:
/* FIXME, detect this differently */
if (demux->priv->srcpad == NULL) { if (demux->priv->srcpad == NULL) {
GST_WARNING_OBJECT (demux, "EOS before we found a type"); GST_WARNING_OBJECT (demux, "EOS before we found a type");
GST_ELEMENT_ERROR (demux, STREAM, TYPE_NOT_FOUND, (NULL), (NULL)); GST_ELEMENT_ERROR (demux, STREAM, TYPE_NOT_FOUND, (NULL), (NULL));