mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

identity: Non-live upstream have no max latency

Browse source 
sync=TRUE implementation changes the latency query of a non-live
upstream into live, though it wrongly set the upstream max latency to 0.
As non-live sources won't loose data if we wait longer, this should have
been reported as have no max latency limite (-1).
This commit is contained in:
Nicolas Dufresne 2019-07-19 21:57:09 -04:00 committed by Tim-Philipp Müller
parent 66e1ee5137
commit 819b316e03
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
plugins/elements/gstidentity.c
View file

@ -976,8 +976,12 @@ gst_identity_query (GstBaseTransform * base, GstPadDirection direction,
GST_OBJECT_LOCK (identity); GST_OBJECT_LOCK (identity);
if (live) if (live)
identity->upstream_latency = min; identity->upstream_latency = min;
else else {
identity->upstream_latency = 0; identity->upstream_latency = 0;
/* if we interface a non-live source, then we know there is no
* limit in the maximum latency */
max = -1;
}
GST_OBJECT_UNLOCK (identity); GST_OBJECT_UNLOCK (identity);
gst_query_set_latency (query, live || identity->sync, min, max); gst_query_set_latency (query, live || identity->sync, min, max);