mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-20 21:16:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

ghostpad: copy sticky events to SRC ghostpads

Browse source 
Update the sticky events on SRC ghostpads when retargeting. This ensures
that the ghostpad has the exect same sticky events as the target pad. We
don't want to do this for SINK ghostpads, they got the events from
downstream and we don't want to overwrite them with the target pad
events.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=707621
This commit is contained in:
Wim Taymans 2013-11-21 14:13:16 +01:00
parent e5c5d3de7e
commit 8162a583a4
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
gst/gstghostpad.c
View file

@ -804,6 +804,26 @@ gst_ghost_pad_get_target (GstGhostPad * gpad)
return ret;
}
static gboolean
clear_sticky_events (GstPad * pad, GstEvent ** event, gpointer user_data)
{
GST_DEBUG_OBJECT (pad, "clearing sticky event %" GST_PTR_FORMAT, *event);
gst_event_unref (*event);
*event = NULL;
return TRUE;
}
static gboolean
copy_sticky_events (GstPad * pad, GstEvent ** event, gpointer user_data)
{
GstPad *internal = GST_PAD_CAST (user_data);
GST_DEBUG_OBJECT (internal, "store sticky event %" GST_PTR_FORMAT, *event);
gst_pad_store_sticky_event (internal, *event);
return TRUE;
}
/**
* gst_ghost_pad_set_target:
* @gpad: the #GstGhostPad
@ -844,6 +864,14 @@ gst_ghost_pad_set_target (GstGhostPad * gpad, GstPad * newtarget)
gst_pad_unlink (internal, oldtarget);
else
gst_pad_unlink (oldtarget, internal);
if (GST_PAD_IS_SRC (gpad)) {
/* only clear the events on the SRC ghostpad. We don't clear sink
* ghostpads, they got their events from downstream and we want to
* set the same events on the target later. */
gst_pad_sticky_events_foreach (GST_PAD_CAST (gpad), clear_sticky_events,
NULL);
}
} else {
GST_OBJECT_UNLOCK (gpad);
}
@ -862,6 +890,13 @@ gst_ghost_pad_set_target (GstGhostPad * gpad, GstPad * newtarget)
if (lret != GST_PAD_LINK_OK)
goto link_failed;
if (GST_PAD_IS_SRC (gpad)) {
/* only copy the events to the SRC ghostpad. We don't copy to sink
* ghostpads, they got their events from downstream and we don't want
* to overwrite those with events from this new target. */
gst_pad_sticky_events_foreach (newtarget, copy_sticky_events, gpad);
}
}
return TRUE;