mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 00:36:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridecodebin3: Avoid repeatedly calling the blocking probe

Browse source 
When skipping an event, we want to unref it and say we handled it. This avoids
being repeatedly called for the same (sticky) events.

The events will be properly propagated once the pad is linked.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3658>
This commit is contained in:
Edward Hervey 2022-12-29 16:01:07 +01:00 committed by Edward Hervey
parent a0655d5131
commit 80e7c31514
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subprojects/gst-plugins-base/gst/playback/gsturidecodebin3.c
View file

@ -1232,7 +1232,10 @@ uri_src_block_probe (GstPad * pad, GstPadProbeInfo * info,
} }
} }
GST_LOG_OBJECT (pad, "Skiping %" GST_PTR_FORMAT, event); GST_LOG_OBJECT (pad, "Skiping %" GST_PTR_FORMAT, event);
return GST_PAD_PROBE_DROP; /* We don't want to be repeatedly called for the same event when unlinked,
* so we mark the event as handled */
gst_mini_object_unref (GST_PAD_PROBE_INFO_DATA (info));
return GST_PAD_PROBE_HANDLED;
} }
PLAY_ITEMS_LOCK (handler->uridecodebin); PLAY_ITEMS_LOCK (handler->uridecodebin);