mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 17:20:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

valve: Fix style, improve comments

Browse source 
Minor improvements to the comments and break a few overly long lines
This commit is contained in:
Olivier Crête 2010-09-30 16:13:23 -04:00 committed by Tim-Philipp Müller
parent f90bddfa39
commit 80a766b39b
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
plugins/elements/gstvalve.c
View file

@ -1,9 +1,7 @@
/* /* GStreamer
* Farsight Voice+Video library * Copyright 2007-2009 Collabora Ltd
*
* Copyright 2007 Collabora Ltd,
* Copyright 2007 Nokia Corporation
* @author: Olivier Crete <olivier.crete@collabora.co.uk> * @author: Olivier Crete <olivier.crete@collabora.co.uk>
* Copyright 2007-2009 Nokia Corporation
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public * modify it under the terms of the GNU Library General Public
@ -21,6 +19,7 @@
* Boston, MA 02111-1307, USA. * Boston, MA 02111-1307, USA.
* *
*/ */
/** /**
* SECTION:element-valve * SECTION:element-valve
* *
@ -117,7 +116,8 @@ gst_valve_class_init (GstValveClass * klass)
g_object_class_install_property (gobject_class, ARG_DROP, g_object_class_install_property (gobject_class, ARG_DROP,
g_param_spec_boolean ("drop", g_param_spec_boolean ("drop",
"Drops all buffers if TRUE", "Drops all buffers if TRUE",
"If this property if TRUE, the element will drop all buffers, if its FALSE, it will let them through", "If this property if TRUE, the element will drop all buffers, "
"if its FALSE, it will let them through",
FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
} }
@ -204,6 +204,9 @@ gst_valve_chain (GstPad * pad, GstBuffer * buffer)
ret = gst_pad_push (valve->srcpad, buffer); ret = gst_pad_push (valve->srcpad, buffer);
/* Ignore errors if "drop" was changed while the thread was blocked
* downwards
*/
GST_OBJECT_LOCK (GST_OBJECT (valve)); GST_OBJECT_LOCK (GST_OBJECT (valve));
if (valve->drop) if (valve->drop)
ret = GST_FLOW_OK; ret = GST_FLOW_OK;
@ -231,6 +234,9 @@ gst_valve_event (GstPad * pad, GstEvent * event)
else else
ret = gst_pad_push_event (valve->srcpad, event); ret = gst_pad_push_event (valve->srcpad, event);
/* Ignore errors if "drop" was changed while the thread was blocked
* downwards.
*/
GST_OBJECT_LOCK (GST_OBJECT (valve)); GST_OBJECT_LOCK (GST_OBJECT (valve));
if (valve->drop) if (valve->drop)
ret = TRUE; ret = TRUE;
@ -257,6 +263,9 @@ gst_valve_buffer_alloc (GstPad * pad, guint64 offset, guint size,
else else
ret = gst_pad_alloc_buffer (valve->srcpad, offset, size, caps, buf); ret = gst_pad_alloc_buffer (valve->srcpad, offset, size, caps, buf);
/* Ignore errors if "drop" was changed while the thread was blocked
* downwards
*/
GST_OBJECT_LOCK (GST_OBJECT (valve)); GST_OBJECT_LOCK (GST_OBJECT (valve));
if (valve->drop) if (valve->drop)
ret = GST_FLOW_OK; ret = GST_FLOW_OK;