mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-27 17:48:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "audioringbuffer: start ringbuffer if needed upon commit"

Browse source 
This reverts commit 13ee94ef10.

Causes audio glitches at startup by starting to output segments
from the ringbuffer before it has been filled / fully prerolled.

https://bugzilla.gnome.org/show_bug.cgi?id=657076
This commit is contained in:
Jan Schmidt 2016-04-16 02:11:59 +10:00
parent 28cf2f02e7
commit 802eae296a
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gst-libs/gst/audio/gstaudioringbuffer.c
View file

@ -1470,18 +1470,6 @@ default_commit (GstAudioRingBuffer * buf, guint64 * sample,
g_return_val_if_fail (buf->memory != NULL, -1); g_return_val_if_fail (buf->memory != NULL, -1);
g_return_val_if_fail (data != NULL, -1); g_return_val_if_fail (data != NULL, -1);
/* writing stuff now, ensure running clock */
if (G_UNLIKELY (g_atomic_int_get (&buf->state) !=
GST_AUDIO_RING_BUFFER_STATE_STARTED)) {
/* see if we are allowed to start it */
if (G_UNLIKELY (g_atomic_int_get (&buf->may_start) == FALSE)) {
GST_DEBUG_OBJECT (buf, "not allowed to start");
} else {
GST_DEBUG_OBJECT (buf, "start!");
gst_audio_ring_buffer_start (buf);
}
}
need_reorder = buf->need_reorder; need_reorder = buf->need_reorder;
channels = buf->spec.info.channels; channels = buf->spec.info.channels;