mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

basetransform: Handle return value of decide_allocation vmethod

Browse source 
If it fails, properly propagate the error
This commit is contained in:
Edward Hervey 2012-02-17 15:09:06 -08:00
parent 60be53fabf
commit 7f8be6935a
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
libs/gst/base/gstbasetransform.c
View file

@ -840,7 +840,8 @@ gst_base_transform_do_bufferpool (GstBaseTransform * trans, GstCaps * outcaps)
GST_DEBUG_OBJECT (trans, "calling decide_allocation"); GST_DEBUG_OBJECT (trans, "calling decide_allocation");
if (G_LIKELY (klass->decide_allocation)) if (G_LIKELY (klass->decide_allocation))
result = klass->decide_allocation (trans, query); if ((result = klass->decide_allocation (trans, query)) == FALSE)
goto no_decide_allocation;
/* we got configuration from our peer, parse them */ /* we got configuration from our peer, parse them */
gst_query_parse_allocation_params (query, &size, &min, &max, &prefix, gst_query_parse_allocation_params (query, &size, &min, &max, &prefix,
@ -874,6 +875,15 @@ gst_base_transform_do_bufferpool (GstBaseTransform * trans, GstCaps * outcaps)
alignment); alignment);
return result; return result;
/* Errors */
no_decide_allocation:
{
GST_WARNING_OBJECT (trans, "Subclass failed to decide allocation");
gst_query_unref (query);
return result;
}
} }
/* function triggered when the in and out caps are negotiated and need /* function triggered when the in and out caps are negotiated and need