mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-22 09:41:07 +00:00
Code Issues 1 Projects Releases Wiki Activity

audioresample: skip pointless loop in broken test_fft unit test

Browse source 
Variable f1 is never used, so just skip that loop for now.

The test has never actually tested actual resampling because of
that bug it seems, and the test fails if fixed to actually resample.

For now we just avoid the pointless 126*12 pipelines that were just
testing the same thing (nothing) over and over again.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7827>
This commit is contained in:
Tim-Philipp Müller 2024-11-04 16:54:34 +00:00 committed by GStreamer Marge Bot
parent 65549da07e
commit 7e9866844f
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subprojects/gst-plugins-base/tests/check/elements/audioresample.c
View file

@ -1216,14 +1216,17 @@ run_fft_pipeline (int inrate, int outrate, int quality, int width,
GST_START_TEST (test_fft) GST_START_TEST (test_fft)
{ {
int quality; int quality;
size_t f0, f1; size_t f0;
static const int frequencies[] = static const int frequencies[] =
{ 8000, 16000, 44100, 48000, 128000, 12345, 54321 }; { 8000, 16000, 44100, 48000, 128000, 12345, 54321 };
/* audioresample uses a mixed float/double code path for floats with quality>8, make sure we test it */ /* audioresample uses a mixed float/double code path for floats with quality>8, make sure we test it */
for (quality = 0; quality <= 10; quality += 5) { for (quality = 0; quality <= 10; quality += 5) {
for (f0 = 0; f0 < G_N_ELEMENTS (frequencies); ++f0) { for (f0 = 0; f0 < G_N_ELEMENTS (frequencies); ++f0) {
for (f1 = 0; f1 < G_N_ELEMENTS (frequencies); ++f1) { // FIXME: actually use f1, currently we just test without resampling!
// (Needs fixes somewhere though because the test fails if fixed)
// for (size_t f1 = 0; f1 < G_N_ELEMENTS (frequencies); ++f1)
{
run_fft_pipeline (frequencies[f0], frequencies[f0], quality, 32, run_fft_pipeline (frequencies[f0], frequencies[f0], quality, 32,
GST_AUDIO_NE (F32), &init_float_silence, &compare_ffts_F32); GST_AUDIO_NE (F32), &init_float_silence, &compare_ffts_F32);
run_fft_pipeline (frequencies[f0], frequencies[f0], quality, 32, run_fft_pipeline (frequencies[f0], frequencies[f0], quality, 32,