mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

plugin: encode: Refine encode's sink caps.

Browse source 
The old manner to get the encode's sink caps is not correct.
Such as 264 encode, it gets:

video/x-raw(memory:VASurface),
format=(string){ ENCODED, NV12, I420, YV12, YUY2, UYVY, Y210,
P010_10LE, AYUV, Y410, Y444 }, width=(int)[ 32, 4096 ],
height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ];
video/x-raw(memory:DMABuf), format=(string){ I420, YV12, RGBA },
width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ],
framerate=(fraction)[ 0/1, 2147483647/1 ];
video/x-raw, format=(string){ NV12 }, width=(int)[ 32, 4096 ],
height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]

where the formats for memory:VASurface and memory:DMABuf are superfluous.
All the "I420, YV12, YUY2, UYVY, Y210, RGBA" can not be really used as
input format for encoder.

We should get:
video/x-raw, format=(string){ NV12 }, width=(int)[ 32, 4096 ],
height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ];
video/x-raw(memory:VASurface), format=(string){ NV12 },
width=(int)[ 32, 4096 ], height=(int)[ 32, 4096 ],
framerate=(fraction)[ 0/1, 2147483647/1 ]; video/x-raw(memory:DMABuf),
format=(string){ NV12 }, width=(int)[ 32, 4096 ],
height=(int)[ 32, 4096 ], framerate=(fraction)[ 0/1, 2147483647/1 ]

as the correct result.
This commit is contained in:
He Junyan 2019-12-06 00:21:12 +08:00 committed by Víctor Manuel Jáquez Leal
parent 4da8dc2550
commit 7ce44bc372
1 changed files with 19 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
gst/vaapi/gstvaapiencode.c
View file

@ -382,7 +382,9 @@ get_entrypoint (GstVaapiEncode * encode, GstVaapiProfile profile)
static gboolean static gboolean
ensure_allowed_sinkpad_caps (GstVaapiEncode * encode) ensure_allowed_sinkpad_caps (GstVaapiEncode * encode)
{ {
GstCaps *out_caps, *raw_caps = NULL; GstCaps *out_caps = NULL;
GstCaps *raw_caps = NULL;
GstCaps *va_caps, *dma_caps;
GArray *formats = NULL; GArray *formats = NULL;
gboolean ret = FALSE; gboolean ret = FALSE;
GstVaapiProfile profile; GstVaapiProfile profile;
@ -398,11 +400,8 @@ ensure_allowed_sinkpad_caps (GstVaapiEncode * encode)
if (profile == GST_VAAPI_PROFILE_UNKNOWN) if (profile == GST_VAAPI_PROFILE_UNKNOWN)
return TRUE; return TRUE;
out_caps = gst_caps_from_string (GST_VAAPI_MAKE_SURFACE_CAPS ";" /* First get all supported formats, all these formats should be recognized
GST_VAAPI_MAKE_DMABUF_CAPS); in video-format map. */
if (!out_caps)
goto failed_create_va_caps;
formats = gst_vaapi_encoder_get_surface_formats (encode->encoder, profile); formats = gst_vaapi_encoder_get_surface_formats (encode->encoder, profile);
if (!formats) if (!formats)
goto failed_get_formats; goto failed_get_formats;
@ -411,9 +410,21 @@ ensure_allowed_sinkpad_caps (GstVaapiEncode * encode)
if (!raw_caps) if (!raw_caps)
goto failed_create_raw_caps; goto failed_create_raw_caps;
out_caps = gst_caps_make_writable (out_caps); va_caps = gst_caps_copy (raw_caps);
gst_caps_append (out_caps, gst_caps_copy (raw_caps)); gst_caps_set_features_simple (va_caps,
gst_caps_features_from_string (GST_CAPS_FEATURE_MEMORY_VAAPI_SURFACE));
dma_caps = gst_caps_copy (raw_caps);
gst_caps_set_features_simple (dma_caps,
gst_caps_features_from_string (GST_CAPS_FEATURE_MEMORY_DMABUF));
/* collect all caps together. */
out_caps = raw_caps;
raw_caps = NULL;
gst_caps_append (out_caps, va_caps);
gst_caps_append (out_caps, dma_caps);
/* Last, set the width/height info to caps */
size = gst_caps_get_size (out_caps); size = gst_caps_get_size (out_caps);
for (i = 0; i < size; i++) { for (i = 0; i < size; i++) {
structure = gst_caps_get_structure (out_caps, i); structure = gst_caps_get_structure (out_caps, i);
@ -438,11 +449,6 @@ bail:
g_array_unref (formats); g_array_unref (formats);
return ret; return ret;
failed_create_va_caps:
{
GST_WARNING_OBJECT (encode, "failed to create VA/GL sink caps");
return FALSE;
}
failed_get_formats: failed_get_formats:
{ {
GST_WARNING_OBJECT (encode, "failed to get allowed surface formats"); GST_WARNING_OBJECT (encode, "failed to get allowed surface formats");