mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 22:36:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2videodec: Fix activation of internal pool

Browse source 
If the driver does not support VIDIOC_CREATE_BUFS ioctl, the pool
configuration may get changed, which requires a validation. This would
fail to activate a pool in a case it shouldn't normally fail unless we
are out of memory.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2456>
This commit is contained in:
Nicolas Dufresne 2022-05-19 15:51:03 -04:00 committed by GStreamer Marge Bot
parent afc94046ba
commit 7c40fcb66e
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c
View file

@ -824,8 +824,18 @@ gst_v4l2_video_dec_handle_frame (GstVideoDecoder * decoder,
self->v4l2output->info.size, min, max);
/* There is no reason to refuse this config */
if (!gst_buffer_pool_set_config (pool, config))
goto activate_failed;
if (!gst_buffer_pool_set_config (pool, config)) {
config = gst_buffer_pool_get_config (pool);
if (!gst_buffer_pool_config_validate_params (config,
self->input_state->caps, self->v4l2output->info.size, min, max)) {
gst_structure_free (config);
goto activate_failed;
}
if (!gst_buffer_pool_set_config (pool, config))
goto activate_failed;
}
if (!gst_buffer_pool_set_active (pool, TRUE))
goto activate_failed;