mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-03 14:08:56 +00:00
Code Issues 1 Projects Releases Wiki Activity

concat: fix qos event handling

Browse source 
We were shadowing the sinkpad variable resulting in:
- the QoS event to be send to all sink pads instead of the active one
- the pad to be leaked

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1543>
This commit is contained in:
Guillaume Desmottes 2021-10-20 11:20:13 +02:00 committed by Tim-Philipp Müller
parent ba873ba8b9
commit 7bf0c5b7be
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
plugins/elements/gstconcat.c
View file

@ -756,14 +756,11 @@ gst_concat_src_event (GstPad * pad, GstObject * parent, GstEvent * event)
break; break;
} }
case GST_EVENT_QOS:{ case GST_EVENT_QOS:{
GstPad *sinkpad = NULL;
g_mutex_lock (&self->lock); g_mutex_lock (&self->lock);
if ((sinkpad = self->current_sinkpad)) if ((sinkpad = self->current_sinkpad))
gst_object_ref (sinkpad); gst_object_ref (sinkpad);
g_mutex_unlock (&self->lock); g_mutex_unlock (&self->lock);
if (!sinkpad) { if (!sinkpad) {
gst_event_replace (&event, NULL); gst_event_replace (&event, NULL);
ret = FALSE; ret = FALSE;