mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-05 15:08:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

alsasink: Improve logging in write() function

Browse source 
This moves the "written X frames" lower so that we don't trace
confusing negative values on errors and add the error code in the
"Write error" log.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1261>
This commit is contained in:
Nicolas Dufresne 2021-08-24 15:26:12 -04:00 committed by GStreamer Marge Bot
parent f3601164d2
commit 7b76c97de9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/alsa/gstalsasink.c
View file

@ -1072,9 +1072,8 @@ gst_alsasink_write (GstAudioSink * asink, gpointer data, guint length)
GST_DELAY_SINK_UNLOCK (asink); GST_DELAY_SINK_UNLOCK (asink);
} }
GST_DEBUG_OBJECT (asink, "written %d frames out of %d", err, cptr);
if (err < 0) { if (err < 0) {
GST_DEBUG_OBJECT (asink, "Write error: %s", snd_strerror (err)); GST_DEBUG_OBJECT (asink, "Write error: %s (%d)", snd_strerror (err), err);
if (err == -EAGAIN) { if (err == -EAGAIN) {
continue; continue;
} else if (err == -ENODEV) { } else if (err == -ENODEV) {
@ -1089,6 +1088,7 @@ gst_alsasink_write (GstAudioSink * asink, gpointer data, guint length)
break; break;
} }
GST_DEBUG_OBJECT (asink, "written %d frames out of %d", err, cptr);
ptr += snd_pcm_frames_to_bytes (alsa->handle, err); ptr += snd_pcm_frames_to_bytes (alsa->handle, err);
cptr -= err; cptr -= err;
} }