mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 09:40:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtsp-server: Fix socket leak

Browse source 
https://bugzilla.gnome.org/show_bug.cgi?id=710088
This commit is contained in:
Ognyan Tonchev 2013-10-14 12:03:07 +02:00 committed by Sebastian Dröge
parent 935e8f852d
commit 7b34d1e915
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/rtsp-server/rtsp-server.c
View file

@ -1078,7 +1078,7 @@ default_create_client (GstRTSPServer * server)
/** /**
* gst_rtsp_server_transfer_connection: * gst_rtsp_server_transfer_connection:
* @server: a #GstRTSPServer * @server: a #GstRTSPServer
* @socket: a network socket * @socket: (transfer full): a network socket
* @ip: the IP address of the remote client * @ip: the IP address of the remote client
* @port: the port used by the other end * @port: the port used by the other end
* @initial_buffer: any initial data that was already read from the socket * @initial_buffer: any initial data that was already read from the socket
@ -1108,6 +1108,7 @@ gst_rtsp_server_transfer_connection (GstRTSPServer * server, GSocket * socket,
GST_RTSP_CHECK (gst_rtsp_connection_create_from_socket (socket, ip, port, GST_RTSP_CHECK (gst_rtsp_connection_create_from_socket (socket, ip, port,
initial_buffer, &conn), no_connection); initial_buffer, &conn), no_connection);
g_object_unref (socket);
/* set connection on the client now */ /* set connection on the client now */
gst_rtsp_client_set_connection (client, conn); gst_rtsp_client_set_connection (client, conn);
@ -1121,6 +1122,7 @@ gst_rtsp_server_transfer_connection (GstRTSPServer * server, GSocket * socket,
client_failed: client_failed:
{ {
GST_ERROR_OBJECT (server, "failed to create a client"); GST_ERROR_OBJECT (server, "failed to create a client");
g_object_unref (socket);
return FALSE; return FALSE;
} }
no_connection: no_connection:
@ -1128,6 +1130,7 @@ no_connection:
gchar *str = gst_rtsp_strresult (res); gchar *str = gst_rtsp_strresult (res);
GST_ERROR ("could not create connection from socket %p: %s", socket, str); GST_ERROR ("could not create connection from socket %p: %s", socket, str);
g_free (str); g_free (str);
g_object_unref (socket);
return FALSE; return FALSE;
} }
} }