mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

camerabin: Fix leaks in the preview handling

Browse source 
Remember to unref the bus after adding the watch.
Remember to unref the element after getting it with
gst_bin_get_by_name.
This commit is contained in:
Thiago Santos 2010-11-02 09:39:49 -03:00
parent 5a5fca2689
commit 7ae195788a
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst/camerabin/camerabinpreview.c
View file

@ -229,6 +229,7 @@ gst_camerabin_preview_convert (GstCameraBin * camera,
bus = gst_element_get_bus (pipeline); bus = gst_element_get_bus (pipeline);
msg = gst_bus_timed_pop_filtered (bus, (25 * GST_SECOND), msg = gst_bus_timed_pop_filtered (bus, (25 * GST_SECOND),
GST_MESSAGE_ERROR | GST_MESSAGE_EOS); GST_MESSAGE_ERROR | GST_MESSAGE_EOS);
gst_bus_unref (bus);
if (msg) { if (msg) {
switch (GST_MESSAGE_TYPE (msg)) { switch (GST_MESSAGE_TYPE (msg)) {
@ -308,15 +309,17 @@ gst_camerabin_preview_send_event (GstCameraBin * camera, GstElement * pipeline,
GstEvent * evt) GstEvent * evt)
{ {
GstElement *src; GstElement *src;
gboolean ret = FALSE;
src = gst_bin_get_by_name (GST_BIN (pipeline), "prev_src"); src = gst_bin_get_by_name (GST_BIN (pipeline), "prev_src");
if (!src) { if (!src) {
GST_WARNING ("Preview pipeline doesn't have src element, can't push event"); GST_WARNING ("Preview pipeline doesn't have src element, can't push event");
gst_event_unref (evt); gst_event_unref (evt);
return FALSE; } else {
GST_DEBUG_OBJECT (camera, "Pushing event %p to preview pipeline", evt);
ret = gst_element_send_event (src, evt);
gst_object_unref (src);
} }
GST_DEBUG_OBJECT (camera, "Pushing event %p to preview pipeline", evt); return ret;
return gst_element_send_event (src, evt);
} }