mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-12 19:14:16 +00:00
Code Issues1 Projects Releases Wiki Activity

video: overlay-composition: fix crash when doing premultiplied<->unpremultiplied alpha conversion

Browse source 
We need to copy the pixels before messing with them, not least
because the buffer creation code below assumes it's ok to take
ownership.

Fixes crash caused by double-free.

https://bugzilla.gnome.org/show_bug.cgi?id=668483
This commit is contained in:
Holger Kaelberer 2012-03-14 17:18:47 +00:00 committed by Tim-Philipp Müller
parent 6b7f25a2f0
commit 7a21d1eb32
1 changed files with 4 additions and 0 deletions

4
gst-libs/gst/video/video-overlay-composition.c
View file

@ -954,6 +954,10 @@ gst_video_overlay_rectangle_get_pixels_argb_internal (GstVideoOverlayRectangle *
if (wanted_width != rectangle->width || wanted_height != rectangle->height) {
video_blend_scale_linear_RGBA (&info, wanted_height, wanted_width);
} else {
/* if we don't have to scale, we have to modify the alpha values, so we
* need to make a copy of the pixel memory (and we take ownership below) */
info.pixels = g_memdup (info.pixels, info.size);
}
if (!gst_video_overlay_rectangle_is_same_alpha_type (rectangle->flags, flags)) {