mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-24 10:41:04 +00:00
vaapidecode: warns if driver will do color conversions
If the downstream feature is system memory, the surface has to be mapped, hence a warning message is logged saying that the driver has to do color conversions. This might be troublesome because not all the color conversion combinations are supported by the VA-API drivers, and there is not a reliable way to know them before hand. https://bugzilla.gnome.org/show_bug.cgi?id=765223
This commit is contained in:
parent
b41db95c4e
commit
79ec3d00ef
1 changed files with 8 additions and 0 deletions
|
@ -259,6 +259,14 @@ gst_vaapidecode_update_src_caps (GstVaapiDecode * decode)
|
|||
if (feature == GST_VAAPI_CAPS_FEATURE_NOT_NEGOTIATED)
|
||||
return FALSE;
|
||||
|
||||
if ((feature == GST_VAAPI_CAPS_FEATURE_SYSTEM_MEMORY ||
|
||||
feature == GST_VAAPI_CAPS_FEATURE_VAAPI_SURFACE)
|
||||
&& format != GST_VIDEO_INFO_FORMAT (&decode->decoded_info)) {
|
||||
GST_FIXME_OBJECT (decode, "validate if driver can convert from %s to %s",
|
||||
gst_video_format_to_string (GST_VIDEO_INFO_FORMAT
|
||||
(&decode->decoded_info)), gst_video_format_to_string (format));
|
||||
}
|
||||
|
||||
switch (feature) {
|
||||
#if (USE_GLX || USE_EGL)
|
||||
case GST_VAAPI_CAPS_FEATURE_GL_TEXTURE_UPLOAD_META:
|
||||
|
|
Loading…
Reference in a new issue