mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 05:46:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtph263ppay: Fix caps leak

Browse source 
Fix leaking caps when downstream has not-fixed caps.

https://bugzilla.gnome.org/show_bug.cgi?id=773515
This commit is contained in:
Havard Graff 2016-06-22 13:59:35 +02:00 committed by Sebastian Dröge
parent fca2d2f9f0
commit 78ab8cbdcd
2 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gst/rtp/gstrtph263ppay.c
View file

@ -266,6 +266,7 @@ gst_rtp_h263p_pay_sink_getcaps (GstRTPBasePayload * payload, GstPad * pad,
* where we are dealing with the depayloader's template caps. In this case * where we are dealing with the depayloader's template caps. In this case
* we should accept any input compatible with our sink template caps. */ * we should accept any input compatible with our sink template caps. */
if (!gst_caps_is_fixed (peercaps)) { if (!gst_caps_is_fixed (peercaps)) {
gst_caps_unref (peercaps);
caps = caps =
gst_pad_get_pad_template_caps (GST_RTP_BASE_PAYLOAD_SINKPAD (payload)); gst_pad_get_pad_template_caps (GST_RTP_BASE_PAYLOAD_SINKPAD (payload));
goto done; goto done;

27
tests/check/elements/rtph263.c
View file

@ -284,6 +284,30 @@ GST_START_TEST (test_h263pdepay_dont_push_empty_frame)
GST_END_TEST; GST_END_TEST;
GST_START_TEST (test_h263ppay_non_fixed_caps)
{
GstHarness *h;
guint8 frame[] = {
0x00, 0x00, 0x80, 0x06, 0x1c, 0xa8, 0x01, 0x04, 0x91, 0xe0, 0x37, 0xff,
0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
};
h = gst_harness_new_parse ("rtph263ppay");
/* Set non-fixed caps after payloader */
gst_harness_set_caps_str (h, "video/x-h263, variant=(string)itu",
"application/x-rtp, clock-rate=[1, MAX]");
gst_harness_push (h, gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
frame, sizeof (frame), 0, sizeof (frame), NULL, NULL));
fail_unless_equals_int (1, gst_harness_buffers_received (h));
gst_harness_teardown (h);
}
GST_END_TEST;
static Suite * static Suite *
rtph263_suite (void) rtph263_suite (void)
{ {
@ -305,6 +329,9 @@ rtph263_suite (void)
test_h263pdepay_fragmented_memory_non_writable_buffer_split_frame); test_h263pdepay_fragmented_memory_non_writable_buffer_split_frame);
tcase_add_test (tc_chain, test_h263pdepay_dont_push_empty_frame); tcase_add_test (tc_chain, test_h263pdepay_dont_push_empty_frame);
suite_add_tcase (s, (tc_chain = tcase_create ("h263ppay")));
tcase_add_test (tc_chain, test_h263ppay_non_fixed_caps);
return s; return s;
} }