mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-22 16:26:39 +00:00
videoaggregator: fix buffer selection when duration=-1
If the src framerate and videoaggreator's output framerate were different, then we were taking every single buffer that had duration=-1 as it came in regardless of the buffer's start time. This caused the src to possibly run at a different speed to the output frames. https://bugzilla.gnome.org/show_bug.cgi?id=744096
This commit is contained in:
parent
b739cf8b7f
commit
783245f1fe
1 changed files with 19 additions and 0 deletions
|
@ -1000,6 +1000,25 @@ gst_videoaggregator_fill_queues (GstVideoAggregator * vagg,
|
||||||
end_time = GST_BUFFER_DURATION (buf);
|
end_time = GST_BUFFER_DURATION (buf);
|
||||||
|
|
||||||
if (end_time == -1) {
|
if (end_time == -1) {
|
||||||
|
start_time = MAX (start_time, segment.start);
|
||||||
|
start_time =
|
||||||
|
gst_segment_to_running_time (&segment, GST_FORMAT_TIME, start_time);
|
||||||
|
|
||||||
|
if (start_time >= output_end_time) {
|
||||||
|
GST_DEBUG_OBJECT (pad, "buffer duration is -1, start_time >= "
|
||||||
|
"output_end_time. Keeping previous buffer");
|
||||||
|
gst_buffer_unref (buf);
|
||||||
|
continue;
|
||||||
|
} else if (start_time < output_start_time) {
|
||||||
|
GST_DEBUG_OBJECT (pad, "buffer duration is -1, start_time < "
|
||||||
|
"output_start_time. Discarding old buffer");
|
||||||
|
gst_buffer_replace (&pad->buffer, buf);
|
||||||
|
gst_buffer_unref (buf);
|
||||||
|
buf = gst_aggregator_pad_steal_buffer (bpad);
|
||||||
|
gst_buffer_unref (buf);
|
||||||
|
need_more_data = TRUE;
|
||||||
|
continue;
|
||||||
|
}
|
||||||
gst_buffer_unref (buf);
|
gst_buffer_unref (buf);
|
||||||
buf = gst_aggregator_pad_steal_buffer (bpad);
|
buf = gst_aggregator_pad_steal_buffer (bpad);
|
||||||
gst_buffer_replace (&pad->buffer, buf);
|
gst_buffer_replace (&pad->buffer, buf);
|
||||||
|
|
Loading…
Reference in a new issue