mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

buffer: make idx argument to gst_buffer_take_memory() signed

Browse source 
Since -1 is acceptable, it should be signed.
This commit is contained in:
Tim-Philipp Müller 2011-07-06 15:13:30 +01:00
parent c87375a813
commit 75c81c2120
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gst/gstbuffer.c
View file

@ -583,19 +583,20 @@ gst_buffer_n_memory (GstBuffer * buffer)
/** /**
* gst_buffer_take_memory: * gst_buffer_take_memory:
* @buffer: a #GstBuffer. * @buffer: a #GstBuffer.
* @idx: the index to add the memory * @idx: the index to add the memory at, or -1 to append it to the end
* @mem: a #GstMemory. * @mem: (transfer: full): a #GstMemory.
* *
* Add the memory block @mem to @buffer at @idx. This function takes ownership of @mem * Add the memory block @mem to @buffer at @idx. This function takes ownership
* and thus doesn't increase its refcount. * of @mem and thus doesn't increase its refcount.
*/ */
void void
gst_buffer_take_memory (GstBuffer * buffer, guint idx, GstMemory * mem) gst_buffer_take_memory (GstBuffer * buffer, gint idx, GstMemory * mem)
{ {
g_return_if_fail (GST_IS_BUFFER (buffer)); g_return_if_fail (GST_IS_BUFFER (buffer));
g_return_if_fail (gst_buffer_is_writable (buffer)); g_return_if_fail (gst_buffer_is_writable (buffer));
g_return_if_fail (mem != NULL); g_return_if_fail (mem != NULL);
g_return_if_fail (idx == -1 || idx <= GST_BUFFER_MEM_LEN (buffer)); g_return_if_fail (idx == -1 ||
(idx >= 0 && idx <= GST_BUFFER_MEM_LEN (buffer)));
_memory_add (buffer, idx, mem); _memory_add (buffer, idx, mem);
} }

2
gst/gstbuffer.h
View file

@ -230,7 +230,7 @@ GstBuffer * gst_buffer_new_allocate (const GstAllocator * allocator, gsiz
/* memory blocks */ /* memory blocks */
guint gst_buffer_n_memory (GstBuffer *buffer); guint gst_buffer_n_memory (GstBuffer *buffer);
void gst_buffer_take_memory (GstBuffer *buffer, guint idx, GstMemory *mem); void gst_buffer_take_memory (GstBuffer *buffer, gint idx, GstMemory *mem);
GstMemory * gst_buffer_peek_memory (GstBuffer *buffer, guint idx, GstMapFlags flags); GstMemory * gst_buffer_peek_memory (GstBuffer *buffer, guint idx, GstMapFlags flags);
void gst_buffer_remove_memory_range (GstBuffer *buffer, guint idx, guint length); void gst_buffer_remove_memory_range (GstBuffer *buffer, guint idx, guint length);