mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: fix race in streamsynchronizer test

Browse source 
Wait for thread to exit before starting to free the
to_push list, otherwise thread might check the final
to_push->next node only after we've freed it already.
This commit is contained in:
Tim-Philipp Müller 2013-11-12 18:58:43 +00:00
parent cd52ff313e
commit 7509343e53
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/check/elements/streamsynchronizer.c
View file

@ -162,7 +162,7 @@ my_sink_event (GstPad * pad, GstObject * parent, GstEvent * event)
return TRUE; return TRUE;
} }
static void static gpointer
my_push_thread (MyPushInfo * pushinfo) my_push_thread (MyPushInfo * pushinfo)
{ {
GList *tmp; GList *tmp;
@ -174,6 +174,9 @@ my_push_thread (MyPushInfo * pushinfo)
else else
gst_pad_push (pushinfo->pad, GST_BUFFER (tmp->data)); gst_pad_push (pushinfo->pad, GST_BUFFER (tmp->data));
} }
GST_INFO ("leaving thread");
return NULL;
} }
GST_START_TEST (test_basic) GST_START_TEST (test_basic)
@ -272,6 +275,9 @@ GST_START_TEST (test_basic)
fail_if (expected != NULL); fail_if (expected != NULL);
/* wait for thread to exit before freeing things */
g_thread_join (thread);
/* Cleanup */ /* Cleanup */
g_list_free (to_push); g_list_free (to_push);
gst_element_release_request_pad (synchr, sinkpad); gst_element_release_request_pad (synchr, sinkpad);