mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-08 07:35:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

av1parse: Fix a latent memory leak in colorimetry setting.

Browse source 
Also delete the useless "have_cinfo" judgement.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2297>
This commit is contained in:
He Junyan 2022-04-26 01:16:06 +08:00 committed by Tim-Philipp Müller
parent f39a473f42
commit 74918ab9ea
1 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c
View file

@ -1177,29 +1177,30 @@ gst_av1_parse_handle_sequence_obu (GstAV1Parse * self, GstAV1OBU * obu)
if (seq_header.color_config.color_description_present_flag) {
GstVideoColorimetry cinfo;
gboolean have_cinfo = TRUE;
gchar *colorimetry = NULL;
if (have_cinfo) {
if (seq_header.color_config.color_range)
cinfo.range = GST_VIDEO_COLOR_RANGE_0_255;
else
cinfo.range = GST_VIDEO_COLOR_RANGE_16_235;
if (seq_header.color_config.color_range)
cinfo.range = GST_VIDEO_COLOR_RANGE_0_255;
else
cinfo.range = GST_VIDEO_COLOR_RANGE_16_235;
cinfo.matrix = gst_video_color_matrix_from_iso
(seq_header.color_config.matrix_coefficients);
cinfo.transfer = gst_video_transfer_function_from_iso
(seq_header.color_config.transfer_characteristics);
cinfo.primaries = gst_video_color_primaries_from_iso
(seq_header.color_config.color_primaries);
colorimetry = gst_video_colorimetry_to_string (&cinfo);
}
cinfo.matrix = gst_video_color_matrix_from_iso
(seq_header.color_config.matrix_coefficients);
cinfo.transfer = gst_video_transfer_function_from_iso
(seq_header.color_config.transfer_characteristics);
cinfo.primaries = gst_video_color_primaries_from_iso
(seq_header.color_config.color_primaries);
if (g_strcmp0 (colorimetry, self->colorimetry)) {
g_clear_pointer (&self->colorimetry, g_free);
colorimetry = gst_video_colorimetry_to_string (&cinfo);
if (g_strcmp0 (colorimetry, self->colorimetry) != 0) {
g_free (self->colorimetry);
self->colorimetry = colorimetry;
colorimetry = NULL;
self->update_caps = TRUE;
}
g_clear_pointer (&colorimetry, g_free);
}
if (self->subsampling_x != seq_header.color_config.subsampling_x) {