fdsrc: fix error setting when uri is invalid

Elements should always set the GError
This commit is contained in:
Thiago Santos 2014-07-07 16:14:32 -03:00
parent ba31faf261
commit 7446cea73d

View file

@ -631,13 +631,18 @@ gst_fd_src_uri_set_uri (GstURIHandler * handler, const gchar * uri,
protocol = gst_uri_get_protocol (uri);
if (strcmp (protocol, "fd") != 0) {
g_set_error (err, GST_URI_ERROR, GST_URI_ERROR_BAD_URI,
"Wrong protocol for fdsrc in uri: '%s'", uri);
g_free (protocol);
return FALSE;
}
g_free (protocol);
if (sscanf (uri, "fd://%d", &fd) != 1 || fd < 0)
if (sscanf (uri, "fd://%d", &fd) != 1 || fd < 0) {
g_set_error (err, GST_URI_ERROR, GST_URI_ERROR_BAD_URI,
"Bad file descriptor number in uri: '%s'", uri);
return FALSE;
}
if ((q = g_strstr_len (uri, -1, "?"))) {
gchar *sp;