mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 10:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

Remove some obsolete FIXMEs

Browse source
This commit is contained in:
Sebastian Dröge 2012-09-18 15:28:31 +02:00
parent f839a615a0
commit 742816df69
3 changed files with 5 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/androidmedia/gstamc.c
View file

@ -181,9 +181,7 @@ initialize_java_vm (void)
options[2].optionString = "-Xcheck:jni"; options[2].optionString = "-Xcheck:jni";
options[3].optionString = "-Xdebug"; options[3].optionString = "-Xdebug";
/* FIXME: Do we need any options here? Like exit() vm_args.version = JNI_VERSION_1_4;
* handler, or classpaths? */
vm_args.version = JNI_VERSION_1_6;
vm_args.options = options; vm_args.options = options;
vm_args.nOptions = 4; vm_args.nOptions = 4;
vm_args.ignoreUnrecognized = JNI_TRUE; vm_args.ignoreUnrecognized = JNI_TRUE;
@ -1679,7 +1677,8 @@ scan_codecs (GstPlugin * plugin)
} }
/* FIXME: Non-Google codecs usually just don't work and hang forever /* FIXME: Non-Google codecs usually just don't work and hang forever
* or crash when not used from a process that started the Java * or crash when not used from a process that started the Java
* VM via the non-public AndroidRuntime class * VM via the non-public AndroidRuntime class. Can we somehow
* initialize all this?
*/ */
if (started_java_vm && !g_str_has_prefix (name_str, "OMX.google.")) { if (started_java_vm && !g_str_has_prefix (name_str, "OMX.google.")) {
GST_INFO ("Skipping non-Google codec in standalone mode"); GST_INFO ("Skipping non-Google codec in standalone mode");

11
sys/androidmedia/gstamcaudiodec.c
View file

@ -339,16 +339,8 @@ gst_amc_audio_dec_close (GstAudioDecoder * decoder)
GST_DEBUG_OBJECT (self, "Closing decoder"); GST_DEBUG_OBJECT (self, "Closing decoder");
if (self->codec) { if (self->codec)
/* FIXME: This crashes for some reason, looks like the
* MediaCodec API is not threadsafe between stop() and
* release()
*/
#if 0
gst_amc_codec_release (self->codec);
#endif
gst_amc_codec_free (self->codec); gst_amc_codec_free (self->codec);
}
self->codec = NULL; self->codec = NULL;
self->started = FALSE; self->started = FALSE;
@ -880,7 +872,6 @@ gst_amc_audio_dec_set_format (GstAudioDecoder * decoder, GstCaps * caps)
GST_DEBUG_OBJECT (self, "Configuring codec with format: %s", format_string); GST_DEBUG_OBJECT (self, "Configuring codec with format: %s", format_string);
g_free (format_string); g_free (format_string);
/* FIXME: Flags? */
if (!gst_amc_codec_configure (self->codec, format, 0)) { if (!gst_amc_codec_configure (self->codec, format, 0)) {
GST_ERROR_OBJECT (self, "Failed to configure codec"); GST_ERROR_OBJECT (self, "Failed to configure codec");
return FALSE; return FALSE;

11
sys/androidmedia/gstamcvideodec.c
View file

@ -450,16 +450,8 @@ gst_amc_video_dec_close (GstVideoDecoder * decoder)
GST_DEBUG_OBJECT (self, "Closing decoder"); GST_DEBUG_OBJECT (self, "Closing decoder");
if (self->codec) { if (self->codec)
/* FIXME: This crashes for some reason, looks like the
* MediaCodec API is not threadsafe between stop() and
* release()
*/
#if 0
gst_amc_codec_release (self->codec);
#endif
gst_amc_codec_free (self->codec); gst_amc_codec_free (self->codec);
}
self->codec = NULL; self->codec = NULL;
self->started = FALSE; self->started = FALSE;
@ -1240,7 +1232,6 @@ gst_amc_video_dec_set_format (GstVideoDecoder * decoder,
GST_DEBUG_OBJECT (self, "Configuring codec with format: %s", format_string); GST_DEBUG_OBJECT (self, "Configuring codec with format: %s", format_string);
g_free (format_string); g_free (format_string);
/* FIXME: Flags? */
if (!gst_amc_codec_configure (self->codec, format, 0)) { if (!gst_amc_codec_configure (self->codec, format, 0)) {
GST_ERROR_OBJECT (self, "Failed to configure codec"); GST_ERROR_OBJECT (self, "Failed to configure codec");
return FALSE; return FALSE;