mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

Fix 'xyz may be used uninitialized' compiler warnings caused by broken g_assert_not_reached() macro in GLib-2.15.x an...

Browse source 
Original commit message from CVS:
* ext/ladspa/gstladspa.c: (gst_ladspa_get_property):
* ext/sdl/sdlvideosink.c: (gst_sdlvideosink_show_frame):
* gst/mve/gstmvemux.c: (gst_mve_mux_request_new_pad):
* sys/dvb/dvbbasebin.c: (dvb_base_bin_class_init):
Fix 'xyz may be used uninitialized' compiler warnings caused
by broken g_assert_not_reached() macro in GLib-2.15.x and don't
abort() in any case but properly report the error.
This commit is contained in:
Sebastian Dröge 2007-12-29 17:31:49 +00:00
parent d56ba2c780
commit 73cc44a5e8
5 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog
View file

@ -1,3 +1,13 @@
2007-12-29 Sebastian Dröge <slomo@circular-chaos.org>
* ext/ladspa/gstladspa.c: (gst_ladspa_get_property):
* ext/sdl/sdlvideosink.c: (gst_sdlvideosink_show_frame):
* gst/mve/gstmvemux.c: (gst_mve_mux_request_new_pad):
* sys/dvb/dvbbasebin.c: (dvb_base_bin_class_init):
Fix 'xyz may be used uninitialized' compiler warnings caused
by broken g_assert_not_reached() macro in GLib-2.15.x and don't
abort() in any case but properly report the error.
2007-12-29 Sebastian Dröge <slomo@circular-chaos.org> 2007-12-29 Sebastian Dröge <slomo@circular-chaos.org>
* configure.ac: * configure.ac:

4
ext/ladspa/gstladspa.c
View file

@ -424,7 +424,7 @@ gst_ladspa_get_property (GObject * object, guint prop_id, GValue * value,
controls = gsp->control_out; controls = gsp->control_out;
prop_id -= gsp_class->num_control_in; prop_id -= gsp_class->num_control_in;
} else { } else {
g_assert_not_reached (); g_return_if_reached ();
} }
/* now see what type it is */ /* now see what type it is */
@ -439,7 +439,7 @@ gst_ladspa_get_property (GObject * object, guint prop_id, GValue * value,
g_value_set_float (value, controls[prop_id]); g_value_set_float (value, controls[prop_id]);
break; break;
default: default:
g_assert_not_reached (); g_return_if_reached ();
} }
} }

4
ext/sdl/sdlvideosink.c
View file

@ -778,7 +778,9 @@ gst_sdlvideosink_show_frame (GstBaseSink * bsink, GstBuffer * buf)
v = y + I420_V_OFFSET (sdlvideosink->width, sdlvideosink->height); v = y + I420_V_OFFSET (sdlvideosink->width, sdlvideosink->height);
break; break;
default: default:
g_assert_not_reached (); gst_sdlvideosink_unlock (sdlvideosink);
g_mutex_unlock (sdlvideosink->lock);
g_return_val_if_reached (GST_FLOW_ERROR);
} }
/* Y Plane */ /* Y Plane */

2
gst/mve/gstmvemux.c
View file

@ -1320,7 +1320,7 @@ gst_mve_mux_request_new_pad (GstElement * element,
mvemux->video_pad_eos = FALSE; mvemux->video_pad_eos = FALSE;
pad = mvemux->videosink; pad = mvemux->videosink;
} else { } else {
g_assert_not_reached (); g_return_val_if_reached (NULL);
} }
gst_pad_set_chain_function (pad, GST_DEBUG_FUNCPTR (gst_mve_mux_chain)); gst_pad_set_chain_function (pad, GST_DEBUG_FUNCPTR (gst_mve_mux_chain));

5
sys/dvb/dvbbasebin.c
View file

@ -276,7 +276,10 @@ dvb_base_bin_class_init (DvbBaseBinClass * klass)
g_param_spec_get_nick (pspec), g_param_spec_get_blurb (pspec), g_param_spec_get_nick (pspec), g_param_spec_get_blurb (pspec),
pspec->value_type, src_pspec->default_value, pspec->flags); pspec->value_type, src_pspec->default_value, pspec->flags);
} else { } else {
g_assert_not_reached (); GST_ERROR ("Unsupported property type %d for property %s",
param_type, g_param_spec_get_name (pspec));
++walk;
continue;
} }
g_object_class_install_property (gobject_class, walk->prop_id, our_pspec); g_object_class_install_property (gobject_class, walk->prop_id, our_pspec);