mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-23 14:36:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/udp/gstudpsrc.c: Fix some leaks in caps and uris. Fixes #361252.

Browse source 
Original commit message from CVS:
Patch by: Sebastien Cote <sebas642 at yahoo dot ca>
* gst/udp/gstudpsrc.c: (gst_udpsrc_class_init),
(gst_udpsrc_finalize), (gst_udpsrc_create), (gst_udpsrc_set_uri),
(gst_udpsrc_start):
Fix some leaks in caps and uris. Fixes #361252.
This commit is contained in:
Sebastien Cote 2006-10-11 08:34:14 +00:00 committed by Wim Taymans
parent 2738e1f8a9
commit 734243efa2
2 changed files with 32 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2006-10-11 Wim Taymans <wim@fluendo.com>
Patch by: Sebastien Cote <sebas642 at yahoo dot ca>
* gst/udp/gstudpsrc.c: (gst_udpsrc_class_init),
(gst_udpsrc_finalize), (gst_udpsrc_create), (gst_udpsrc_set_uri),
(gst_udpsrc_start):
Fix some leaks in caps and uris. Fixes #361252.
2006-10-10 Tim-Philipp Müller <tim at centricular dot net> 2006-10-10 Tim-Philipp Müller <tim at centricular dot net>
* gst/wavparse/Makefile.am: * gst/wavparse/Makefile.am:

31
gst/udp/gstudpsrc.c
View file

@ -177,6 +177,7 @@ static GstFlowReturn gst_udpsrc_create (GstPushSrc * psrc, GstBuffer ** buf);
static gboolean gst_udpsrc_start (GstBaseSrc * bsrc); static gboolean gst_udpsrc_start (GstBaseSrc * bsrc);
static gboolean gst_udpsrc_stop (GstBaseSrc * bsrc); static gboolean gst_udpsrc_stop (GstBaseSrc * bsrc);
static gboolean gst_udpsrc_unlock (GstBaseSrc * bsrc); static gboolean gst_udpsrc_unlock (GstBaseSrc * bsrc);
static void gst_udpsrc_finalize (GObject * object);
static void gst_udpsrc_set_property (GObject * object, guint prop_id, static void gst_udpsrc_set_property (GObject * object, guint prop_id,
const GValue * value, GParamSpec * pspec); const GValue * value, GParamSpec * pspec);
@ -224,6 +225,7 @@ gst_udpsrc_class_init (GstUDPSrcClass * klass)
gobject_class->set_property = gst_udpsrc_set_property; gobject_class->set_property = gst_udpsrc_set_property;
gobject_class->get_property = gst_udpsrc_get_property; gobject_class->get_property = gst_udpsrc_get_property;
gobject_class->finalize = gst_udpsrc_finalize;
g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_PORT, g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_PORT,
g_param_spec_int ("port", "Port", g_param_spec_int ("port", "Port",
@ -278,6 +280,21 @@ gst_udpsrc_init (GstUDPSrc * udpsrc, GstUDPSrcClass * g_class)
udpsrc->control_sock[1] = -1; udpsrc->control_sock[1] = -1;
} }
static void
gst_udpsrc_finalize (GObject * object)
{
GstUDPSrc *udpsrc;
udpsrc = GST_UDPSRC (object);
if (udpsrc->caps)
gst_caps_unref (udpsrc->caps);
g_free (udpsrc->multi_group);
g_free (udpsrc->uri);
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static GstCaps * static GstCaps *
gst_udpsrc_getcaps (GstBaseSrc * src) gst_udpsrc_getcaps (GstBaseSrc * src)
{ {
@ -408,8 +425,8 @@ gst_udpsrc_create (GstPushSrc * psrc, GstBuffer ** buf)
pktdata = g_malloc (readsize); pktdata = g_malloc (readsize);
pktsize = readsize; pktsize = readsize;
len = sizeof (struct sockaddr);
while (TRUE) { while (TRUE) {
len = sizeof (struct sockaddr);
ret = recvfrom (udpsrc->sock, pktdata, pktsize, ret = recvfrom (udpsrc->sock, pktdata, pktsize,
0, (struct sockaddr *) &tmpaddr, &len); 0, (struct sockaddr *) &tmpaddr, &len);
if (ret < 0) { if (ret < 0) {
@ -503,11 +520,12 @@ gst_udpsrc_set_uri (GstUDPSrc * src, const gchar * uri)
return TRUE; return TRUE;
/* ERRORS */
wrong_protocol: wrong_protocol:
{ {
g_free (protocol); g_free (protocol);
GST_ELEMENT_ERROR (src, RESOURCE, READ, (NULL), GST_ELEMENT_ERROR (src, RESOURCE, READ, (NULL),
("error parsing uri %s: wrong protocol", uri)); ("error parsing uri %s: wrong protocol (%s != udp)", uri, protocol));
return FALSE; return FALSE;
} }
} }
@ -652,8 +670,7 @@ gst_udpsrc_start (GstBaseSrc * bsrc)
src->myaddr.sin_addr.s_addr = INADDR_ANY; src->myaddr.sin_addr.s_addr = INADDR_ANY;
GST_DEBUG_OBJECT (src, "binding on port %d", src->port); GST_DEBUG_OBJECT (src, "binding on port %d", src->port);
if ((ret = if ((ret = bind (src->sock, (struct sockaddr *) &src->myaddr,
bind (src->sock, (struct sockaddr *) &src->myaddr,
sizeof (src->myaddr))) < 0) sizeof (src->myaddr))) < 0)
goto bind_error; goto bind_error;
} }
@ -661,8 +678,7 @@ gst_udpsrc_start (GstBaseSrc * bsrc)
if (inet_aton (src->multi_group, &(src->multi_addr.imr_multiaddr))) { if (inet_aton (src->multi_group, &(src->multi_addr.imr_multiaddr))) {
if (src->multi_addr.imr_multiaddr.s_addr) { if (src->multi_addr.imr_multiaddr.s_addr) {
src->multi_addr.imr_interface.s_addr = INADDR_ANY; src->multi_addr.imr_interface.s_addr = INADDR_ANY;
if ((ret = if ((ret = setsockopt (src->sock, IPPROTO_IP, IP_ADD_MEMBERSHIP,
setsockopt (src->sock, IPPROTO_IP, IP_ADD_MEMBERSHIP,
&src->multi_addr, sizeof (src->multi_addr))) < 0) &src->multi_addr, sizeof (src->multi_addr))) < 0)
goto membership; goto membership;
} }
@ -695,8 +711,7 @@ gst_udpsrc_start (GstBaseSrc * bsrc)
GST_DEBUG_OBJECT (src, "could not get udp buffer size"); GST_DEBUG_OBJECT (src, "could not get udp buffer size");
bc_val = 1; bc_val = 1;
if ((ret = if ((ret = setsockopt (src->sock, SOL_SOCKET, SO_BROADCAST, &bc_val,
setsockopt (src->sock, SOL_SOCKET, SO_BROADCAST, &bc_val,
sizeof (bc_val))) < 0) sizeof (bc_val))) < 0)
goto no_broadcast; goto no_broadcast;