mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-29 21:21:12 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin3: Provide clear error message if no decoders present

Browse source 
If we don't do this we will end up with a more cryptic error message (not-linked
error from some upstream component).

Fixes #3198

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6317>
This commit is contained in:
Edward Hervey 2024-03-11 09:16:01 +01:00
parent 1032d58187
commit 73152b53ff
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c
View file

@ -2424,15 +2424,20 @@ check_slot_reconfiguration (GstDecodebin3 * dbin, MultiQueueSlot * slot)
} }
if (!reconfigure_output_stream (output, slot, &msg)) { if (!reconfigure_output_stream (output, slot, &msg)) {
gboolean no_more_streams;
GST_DEBUG_OBJECT (dbin, "Removing failing stream from selection: %s ", GST_DEBUG_OBJECT (dbin, "Removing failing stream from selection: %s ",
gst_stream_get_stream_id (slot->active_stream)); gst_stream_get_stream_id (slot->active_stream));
slot->dbin->requested_selection = slot->dbin->requested_selection =
remove_from_list (slot->dbin->requested_selection, remove_from_list (slot->dbin->requested_selection,
gst_stream_get_stream_id (slot->active_stream)); gst_stream_get_stream_id (slot->active_stream));
no_more_streams = slot->dbin->requested_selection == NULL;
dbin->selection_updated = TRUE; dbin->selection_updated = TRUE;
SELECTION_UNLOCK (dbin); SELECTION_UNLOCK (dbin);
if (msg) if (msg)
gst_element_post_message ((GstElement *) slot->dbin, msg); gst_element_post_message ((GstElement *) slot->dbin, msg);
if (no_more_streams)
GST_ELEMENT_ERROR (slot->dbin, CORE, MISSING_PLUGIN, (NULL),
("no suitable plugins found"));
reassign_slot (dbin, slot); reassign_slot (dbin, slot);
} else { } else {
GstMessage *selection_msg = is_selection_done (dbin); GstMessage *selection_msg = is_selection_done (dbin);
@ -3062,7 +3067,10 @@ reconfigure_output_stream (DecodebinOutputStream * output,
missing_decoder: missing_decoder:
{ {
GstCaps *caps; GstCaps *caps;
caps = gst_stream_get_caps (slot->active_stream); caps = gst_stream_get_caps (slot->active_stream);
GST_DEBUG_OBJECT (slot->src_pad,
"We are missing a decoder for %" GST_PTR_FORMAT, caps);
*msg = gst_missing_decoder_message_new (GST_ELEMENT_CAST (dbin), caps); *msg = gst_missing_decoder_message_new (GST_ELEMENT_CAST (dbin), caps);
gst_caps_unref (caps); gst_caps_unref (caps);
} }