mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 19:42:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

design: subtitle-overlays: drop unneeded scaping & add missing markup

Browse source 
Additionally, drop manual padding on final launch example.
This commit is contained in:
Reynaldo H. Verdejo Pinochet 2017-01-23 14:40:08 -08:00
parent 71cb8da117
commit 730ed0da1e
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
markdown/design/subtitle-overlays.md
View file

@ -154,14 +154,14 @@ Multiple possible solutions come to mind:
One would have to do implement a special kind of new query (e.g. One would have to do implement a special kind of new query (e.g.
FEATURE query) that is not passed on automatically by FEATURE query) that is not passed on automatically by
gst\_pad\_query\_default() in order to make sure that all elements `gst_pad_query_default()` in order to make sure that all elements
downstream will handle the attached overlay data. (This is only a downstream will handle the attached overlay data. (This is only a
problem if we want to also attach overlay data to raw video pixel problem if we want to also attach overlay data to raw video pixel
buffers; for new non-raw types we can just make it mandatory and buffers; for new non-raw types we can just make it mandatory and
assume support and be done with it; for existing non-raw types assume support and be done with it; for existing non-raw types
nothing changes anyway if subtitles don't work) (we need to maintain nothing changes anyway if subtitles don't work) (we need to maintain
backwards compatibility for existing raw video pipelines like e.g.: backwards compatibility for existing raw video pipelines like e.g.:
..decoder \! suboverlay \! encoder..) `..decoder ! suboverlay ! encoder..`)
Even though slightly more work, attaching the overlay information to Even though slightly more work, attaching the overlay information to
buffers seems more intuitive than sending it interleaved as events. buffers seems more intuitive than sending it interleaved as events.
@ -523,7 +523,7 @@ TEST: should these look (roughly) alike (note text distortion) - needs
fixing in textoverlay fixing in textoverlay
``` ```
gst-launch-1.0 \ gst-launch-1.0 \
videotestsrc ! video/x-raw,width=640,height=480,pixel-aspect-ratio=1/1 \ videotestsrc ! video/x-raw,width=640,height=480,pixel-aspect-ratio=1/1 \
! textoverlay text=Hello font-desc=72 ! xvimagesink \ ! textoverlay text=Hello font-desc=72 ! xvimagesink \
videotestsrc ! video/x-raw,width=320,height=480,pixel-aspect-ratio=2/1 \ videotestsrc ! video/x-raw,width=320,height=480,pixel-aspect-ratio=2/1 \