mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

aggregator: Take pad lock while releasing buffers when removing pads

Browse source 
Accessing the buffers in all other places requires the pad lock and not
taking it here can cause access to already freed buffers if there's
concurrent access from another thread.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5510>
This commit is contained in:
Sebastian Dröge 2023-10-19 19:43:26 +03:00 committed by GStreamer Marge Bot
parent f7d4ea6eec
commit 70ee7293e0
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gstreamer/libs/gst/base/gstaggregator.c
View file

@ -2122,7 +2122,9 @@ gst_aggregator_release_pad (GstElement * element, GstPad * pad)
SRC_LOCK (self);
gst_aggregator_pad_set_flushing (aggpad, GST_FLOW_FLUSHING, TRUE);
PAD_LOCK (aggpad);
gst_buffer_replace (&aggpad->priv->peeked_buffer, NULL);
PAD_UNLOCK (aggpad);
gst_element_remove_pad (element, pad);
self->priv->has_peer_latency = FALSE;