mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-07 12:21:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

pad: Fix iterator aggregation of all pads in the internal links fallback

Browse source 
g_list_prepend() returns the new head of the list and not
using this will create a memory leak and a single-element list.
This commit is contained in:
Sebastian Dröge 2010-06-13 16:27:39 +02:00
parent 18f23bc0b0
commit 6ff314c75a
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/gstpad.c
View file

@ -3266,9 +3266,9 @@ gst_pad_iterate_internal_links (GstPad * pad)
#ifndef GST_REMOVE_DEPRECATED
static void
add_unref_pad_to_list (GstPad * pad, GList * list)
add_unref_pad_to_list (GstPad * pad, GList ** list)
{
list = g_list_prepend (list, pad);
*list = g_list_prepend (*list, pad);
gst_object_unref (pad);
}
#endif
@ -3318,7 +3318,7 @@ gst_pad_get_internal_links_default (GstPad * pad)
/* loop over the iterator and put all elements into a list, we also
* immediatly unref them, which is bad. */
do {
ires = gst_iterator_foreach (it, (GFunc) add_unref_pad_to_list, res);
ires = gst_iterator_foreach (it, (GFunc) add_unref_pad_to_list, &res);
switch (ires) {
case GST_ITERATOR_OK:
case GST_ITERATOR_DONE: