mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2025-01-03 14:08:56 +00:00
testsuite/schedulers/: Added testsuite for bug 142183 in its two incarnations. Refcount is not increased for schedule...
Original commit message from CVS: * testsuite/schedulers/142183-2.c: (handoff_identity), (main): * testsuite/schedulers/142183.c: (handoff_identity), (main): * testsuite/schedulers/Makefile.am: Added testsuite for bug 142183 in its two incarnations. Refcount is not increased for scheduled elements and threadsafe properties mutexes are not properly unlocked.
This commit is contained in:
Wim Taymans
parent
74060a4ff6
commit
6f82a0ea1a
7 changed files with 343 additions and 2 deletions
|
|
@ -1,3 +1,12 @@
|
||||||
|
2004-07-16 Wim Taymans <wim@fluendo.com>
|
||||||
|
|
||||||
|
* testsuite/schedulers/142183-2.c: (handoff_identity), (main):
|
||||||
|
* testsuite/schedulers/142183.c: (handoff_identity), (main):
|
||||||
|
* testsuite/schedulers/Makefile.am:
|
||||||
|
Added testsuite for bug 142183 in its two incarnations. Refcount
|
||||||
|
is not increased for scheduled elements and threadsafe properties
|
||||||
|
mutexes are not properly unlocked.
|
||||||
|
|
||||||
2004-07-16 Wim Taymans <wim@fluendo.com>
|
2004-07-16 Wim Taymans <wim@fluendo.com>
|
||||||
|
|
||||||
* gst/schedulers/gstoptimalscheduler.c: (gst_opt_scheduler_init),
|
* gst/schedulers/gstoptimalscheduler.c: (gst_opt_scheduler_init),
|
||||||
|
|
|
||||||
72
tests/old/testsuite/schedulers/142183-2.c
Normal file
72
tests/old/testsuite/schedulers/142183-2.c
Normal file
|
|
@ -0,0 +1,72 @@
|
||||||
|
/* GStreamer
|
||||||
|
* Copyright (C) 2004 Wim Taymans <wim@fluendo.com>
|
||||||
|
*
|
||||||
|
* This library is free software; you can redistribute it and/or
|
||||||
|
* modify it under the terms of the GNU General Public
|
||||||
|
* License as published by the Free Software Foundation; either
|
||||||
|
* version 2 of the License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This library is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||||
|
* General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public
|
||||||
|
* License along with this library; if not, write to the Free
|
||||||
|
* Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <gst/gst.h>
|
||||||
|
|
||||||
|
static void
|
||||||
|
handoff_identity (GstElement * element)
|
||||||
|
{
|
||||||
|
GstBin *parent;
|
||||||
|
|
||||||
|
parent = GST_BIN (gst_element_get_parent (element));
|
||||||
|
g_print ("identity handoff\n");
|
||||||
|
/* element is unreffed and destroyed here, which will cause
|
||||||
|
* an assert */
|
||||||
|
gst_bin_remove (parent, element);
|
||||||
|
}
|
||||||
|
|
||||||
|
gint
|
||||||
|
main (gint argc, gchar ** argv)
|
||||||
|
{
|
||||||
|
GstElement *pipeline, *src, *sink, *id;
|
||||||
|
|
||||||
|
gst_init (&argc, &argv);
|
||||||
|
|
||||||
|
g_print ("setting up...\n");
|
||||||
|
/* setup pipeline */
|
||||||
|
pipeline = gst_element_factory_make ("pipeline", NULL);
|
||||||
|
g_assert (pipeline);
|
||||||
|
src = gst_element_factory_make ("fakesrc", NULL);
|
||||||
|
g_assert (src);
|
||||||
|
id = gst_element_factory_make ("identity", NULL);
|
||||||
|
g_assert (id);
|
||||||
|
g_signal_connect (G_OBJECT (id), "handoff", (GCallback) handoff_identity,
|
||||||
|
NULL);
|
||||||
|
g_object_set (G_OBJECT (id), "loop-based", TRUE, NULL);
|
||||||
|
|
||||||
|
sink = gst_element_factory_make ("fakesink", NULL);
|
||||||
|
g_assert (sink);
|
||||||
|
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), src, id, sink, NULL);
|
||||||
|
gst_element_link_pads (src, "src", id, "sink");
|
||||||
|
gst_element_link_pads (id, "src", sink, "sink");
|
||||||
|
|
||||||
|
if (gst_element_set_state (pipeline, GST_STATE_PLAYING) != GST_STATE_SUCCESS)
|
||||||
|
g_assert_not_reached ();
|
||||||
|
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
g_print ("got past iteration, scheduler refs elements correctly\n");
|
||||||
|
|
||||||
|
g_print ("cleaning up...\n");
|
||||||
|
gst_object_unref (GST_OBJECT (pipeline));
|
||||||
|
src = id = sink = pipeline = NULL;
|
||||||
|
|
||||||
|
g_print ("done.\n");
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
94
tests/old/testsuite/schedulers/142183.c
Normal file
94
tests/old/testsuite/schedulers/142183.c
Normal file
|
|
@ -0,0 +1,94 @@
|
||||||
|
/* GStreamer
|
||||||
|
* Copyright (C) 2004 Wim Taymans <wim@fluendo.com>
|
||||||
|
*
|
||||||
|
* This library is free software; you can redistribute it and/or
|
||||||
|
* modify it under the terms of the GNU General Public
|
||||||
|
* License as published by the Free Software Foundation; either
|
||||||
|
* version 2 of the License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This library is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||||
|
* General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public
|
||||||
|
* License along with this library; if not, write to the Free
|
||||||
|
* Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <unistd.h>
|
||||||
|
|
||||||
|
#include <gst/gst.h>
|
||||||
|
|
||||||
|
static void
|
||||||
|
handoff_identity (GstElement * element)
|
||||||
|
{
|
||||||
|
GstBin *parent;
|
||||||
|
|
||||||
|
parent = GST_BIN (gst_element_get_parent (element));
|
||||||
|
g_print ("identity handoff\n");
|
||||||
|
gst_bin_remove (parent, element);
|
||||||
|
}
|
||||||
|
|
||||||
|
gint
|
||||||
|
main (gint argc, gchar ** argv)
|
||||||
|
{
|
||||||
|
GstElement *pipeline, *src, *sink, *id;
|
||||||
|
|
||||||
|
gst_init (&argc, &argv);
|
||||||
|
|
||||||
|
g_print ("setting up...\n");
|
||||||
|
/* setup pipeline */
|
||||||
|
pipeline = gst_element_factory_make ("pipeline", NULL);
|
||||||
|
g_assert (pipeline);
|
||||||
|
src = gst_element_factory_make ("fakesrc", NULL);
|
||||||
|
g_assert (src);
|
||||||
|
id = gst_element_factory_make ("identity", NULL);
|
||||||
|
g_assert (id);
|
||||||
|
/* ref object here as it will be unparented and destroyed in the
|
||||||
|
* handoff signal, normally the scheduler should keep a ref to the
|
||||||
|
* currently scheduled elements but that's another bug displayed in
|
||||||
|
* 142183-2.c */
|
||||||
|
gst_object_ref (GST_OBJECT (id));
|
||||||
|
g_signal_connect (G_OBJECT (id), "handoff", (GCallback) handoff_identity,
|
||||||
|
NULL);
|
||||||
|
g_object_set (G_OBJECT (id), "loop-based", TRUE, NULL);
|
||||||
|
|
||||||
|
sink = gst_element_factory_make ("fakesink", NULL);
|
||||||
|
g_assert (sink);
|
||||||
|
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), src, id, sink, NULL);
|
||||||
|
/* this is what triggers the bug */
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (src));
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (id));
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (sink));
|
||||||
|
|
||||||
|
gst_element_link_pads (src, "src", id, "sink");
|
||||||
|
gst_element_link_pads (id, "src", sink, "sink");
|
||||||
|
|
||||||
|
if (gst_element_set_state (pipeline, GST_STATE_PLAYING) != GST_STATE_SUCCESS)
|
||||||
|
g_assert_not_reached ();
|
||||||
|
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
|
||||||
|
/* 'cause we're going into deadlock mode */
|
||||||
|
alarm (5);
|
||||||
|
|
||||||
|
g_print ("adding identity back...\n");
|
||||||
|
/* add identity back in */
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), id, NULL);
|
||||||
|
|
||||||
|
g_print ("going into possible deadlock... alarm at 5 seconds\n");
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
g_print ("ok, no deadlock. bug 142183 fixed!\n");
|
||||||
|
|
||||||
|
g_print ("cleaning up...\n");
|
||||||
|
gst_object_unref (GST_OBJECT (pipeline));
|
||||||
|
gst_object_unref (GST_OBJECT (id));
|
||||||
|
src = id = sink = pipeline = NULL;
|
||||||
|
|
||||||
|
g_print ("done.\n");
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
@ -9,7 +9,7 @@ tests_pass = \
|
||||||
# don't enable this one unless it actually works.
|
# don't enable this one unless it actually works.
|
||||||
# useless_iteration
|
# useless_iteration
|
||||||
|
|
||||||
tests_fail =
|
tests_fail = 142183 142183-2
|
||||||
tests_ignore =
|
tests_ignore =
|
||||||
|
|
||||||
unlink_src_SOURCES = unlink.c
|
unlink_src_SOURCES = unlink.c
|
||||||
|
|
|
||||||
72
testsuite/schedulers/142183-2.c
Normal file
72
testsuite/schedulers/142183-2.c
Normal file
|
|
@ -0,0 +1,72 @@
|
||||||
|
/* GStreamer
|
||||||
|
* Copyright (C) 2004 Wim Taymans <wim@fluendo.com>
|
||||||
|
*
|
||||||
|
* This library is free software; you can redistribute it and/or
|
||||||
|
* modify it under the terms of the GNU General Public
|
||||||
|
* License as published by the Free Software Foundation; either
|
||||||
|
* version 2 of the License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This library is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||||
|
* General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public
|
||||||
|
* License along with this library; if not, write to the Free
|
||||||
|
* Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <gst/gst.h>
|
||||||
|
|
||||||
|
static void
|
||||||
|
handoff_identity (GstElement * element)
|
||||||
|
{
|
||||||
|
GstBin *parent;
|
||||||
|
|
||||||
|
parent = GST_BIN (gst_element_get_parent (element));
|
||||||
|
g_print ("identity handoff\n");
|
||||||
|
/* element is unreffed and destroyed here, which will cause
|
||||||
|
* an assert */
|
||||||
|
gst_bin_remove (parent, element);
|
||||||
|
}
|
||||||
|
|
||||||
|
gint
|
||||||
|
main (gint argc, gchar ** argv)
|
||||||
|
{
|
||||||
|
GstElement *pipeline, *src, *sink, *id;
|
||||||
|
|
||||||
|
gst_init (&argc, &argv);
|
||||||
|
|
||||||
|
g_print ("setting up...\n");
|
||||||
|
/* setup pipeline */
|
||||||
|
pipeline = gst_element_factory_make ("pipeline", NULL);
|
||||||
|
g_assert (pipeline);
|
||||||
|
src = gst_element_factory_make ("fakesrc", NULL);
|
||||||
|
g_assert (src);
|
||||||
|
id = gst_element_factory_make ("identity", NULL);
|
||||||
|
g_assert (id);
|
||||||
|
g_signal_connect (G_OBJECT (id), "handoff", (GCallback) handoff_identity,
|
||||||
|
NULL);
|
||||||
|
g_object_set (G_OBJECT (id), "loop-based", TRUE, NULL);
|
||||||
|
|
||||||
|
sink = gst_element_factory_make ("fakesink", NULL);
|
||||||
|
g_assert (sink);
|
||||||
|
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), src, id, sink, NULL);
|
||||||
|
gst_element_link_pads (src, "src", id, "sink");
|
||||||
|
gst_element_link_pads (id, "src", sink, "sink");
|
||||||
|
|
||||||
|
if (gst_element_set_state (pipeline, GST_STATE_PLAYING) != GST_STATE_SUCCESS)
|
||||||
|
g_assert_not_reached ();
|
||||||
|
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
g_print ("got past iteration, scheduler refs elements correctly\n");
|
||||||
|
|
||||||
|
g_print ("cleaning up...\n");
|
||||||
|
gst_object_unref (GST_OBJECT (pipeline));
|
||||||
|
src = id = sink = pipeline = NULL;
|
||||||
|
|
||||||
|
g_print ("done.\n");
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
94
testsuite/schedulers/142183.c
Normal file
94
testsuite/schedulers/142183.c
Normal file
|
|
@ -0,0 +1,94 @@
|
||||||
|
/* GStreamer
|
||||||
|
* Copyright (C) 2004 Wim Taymans <wim@fluendo.com>
|
||||||
|
*
|
||||||
|
* This library is free software; you can redistribute it and/or
|
||||||
|
* modify it under the terms of the GNU General Public
|
||||||
|
* License as published by the Free Software Foundation; either
|
||||||
|
* version 2 of the License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This library is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||||
|
* General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public
|
||||||
|
* License along with this library; if not, write to the Free
|
||||||
|
* Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <unistd.h>
|
||||||
|
|
||||||
|
#include <gst/gst.h>
|
||||||
|
|
||||||
|
static void
|
||||||
|
handoff_identity (GstElement * element)
|
||||||
|
{
|
||||||
|
GstBin *parent;
|
||||||
|
|
||||||
|
parent = GST_BIN (gst_element_get_parent (element));
|
||||||
|
g_print ("identity handoff\n");
|
||||||
|
gst_bin_remove (parent, element);
|
||||||
|
}
|
||||||
|
|
||||||
|
gint
|
||||||
|
main (gint argc, gchar ** argv)
|
||||||
|
{
|
||||||
|
GstElement *pipeline, *src, *sink, *id;
|
||||||
|
|
||||||
|
gst_init (&argc, &argv);
|
||||||
|
|
||||||
|
g_print ("setting up...\n");
|
||||||
|
/* setup pipeline */
|
||||||
|
pipeline = gst_element_factory_make ("pipeline", NULL);
|
||||||
|
g_assert (pipeline);
|
||||||
|
src = gst_element_factory_make ("fakesrc", NULL);
|
||||||
|
g_assert (src);
|
||||||
|
id = gst_element_factory_make ("identity", NULL);
|
||||||
|
g_assert (id);
|
||||||
|
/* ref object here as it will be unparented and destroyed in the
|
||||||
|
* handoff signal, normally the scheduler should keep a ref to the
|
||||||
|
* currently scheduled elements but that's another bug displayed in
|
||||||
|
* 142183-2.c */
|
||||||
|
gst_object_ref (GST_OBJECT (id));
|
||||||
|
g_signal_connect (G_OBJECT (id), "handoff", (GCallback) handoff_identity,
|
||||||
|
NULL);
|
||||||
|
g_object_set (G_OBJECT (id), "loop-based", TRUE, NULL);
|
||||||
|
|
||||||
|
sink = gst_element_factory_make ("fakesink", NULL);
|
||||||
|
g_assert (sink);
|
||||||
|
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), src, id, sink, NULL);
|
||||||
|
/* this is what triggers the bug */
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (src));
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (id));
|
||||||
|
gst_element_enable_threadsafe_properties (GST_ELEMENT (sink));
|
||||||
|
|
||||||
|
gst_element_link_pads (src, "src", id, "sink");
|
||||||
|
gst_element_link_pads (id, "src", sink, "sink");
|
||||||
|
|
||||||
|
if (gst_element_set_state (pipeline, GST_STATE_PLAYING) != GST_STATE_SUCCESS)
|
||||||
|
g_assert_not_reached ();
|
||||||
|
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
|
||||||
|
/* 'cause we're going into deadlock mode */
|
||||||
|
alarm (5);
|
||||||
|
|
||||||
|
g_print ("adding identity back...\n");
|
||||||
|
/* add identity back in */
|
||||||
|
gst_bin_add_many (GST_BIN (pipeline), id, NULL);
|
||||||
|
|
||||||
|
g_print ("going into possible deadlock... alarm at 5 seconds\n");
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
gst_bin_iterate (GST_BIN (pipeline));
|
||||||
|
g_print ("ok, no deadlock. bug 142183 fixed!\n");
|
||||||
|
|
||||||
|
g_print ("cleaning up...\n");
|
||||||
|
gst_object_unref (GST_OBJECT (pipeline));
|
||||||
|
gst_object_unref (GST_OBJECT (id));
|
||||||
|
src = id = sink = pipeline = NULL;
|
||||||
|
|
||||||
|
g_print ("done.\n");
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
@ -9,7 +9,7 @@ tests_pass = \
|
||||||
# don't enable this one unless it actually works.
|
# don't enable this one unless it actually works.
|
||||||
# useless_iteration
|
# useless_iteration
|
||||||
|
|
||||||
tests_fail =
|
tests_fail = 142183 142183-2
|
||||||
tests_ignore =
|
tests_ignore =
|
||||||
|
|
||||||
unlink_src_SOURCES = unlink.c
|
unlink_src_SOURCES = unlink.c
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue