mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

bufferpool: log reason for discarded buffers

Browse source 
PERFORMANCE log the reason why a buffer could not be recycled in the
bufferpool.
This commit is contained in:
Wim Taymans 2014-12-16 12:21:59 +01:00
parent 755a66b6a2
commit 6f136b5399
1 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
gst/gstbufferpool.c
View file

@ -1228,17 +1228,17 @@ default_release_buffer (GstBufferPool * pool, GstBuffer * buffer)
GST_MINI_OBJECT_FLAGS (buffer)); GST_MINI_OBJECT_FLAGS (buffer));
/* memory should be untouched */ /* memory should be untouched */
if (GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_TAG_MEMORY)) if (G_UNLIKELY (GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_TAG_MEMORY)))
goto discard; goto memory_tagged;
/* size should have been reset. This is not a catch all, pool with /* size should have been reset. This is not a catch all, pool with
* size requirement per memory should do their own check. */ * size requirement per memory should do their own check. */
if (gst_buffer_get_size (buffer) != pool->priv->size) if (G_UNLIKELY (gst_buffer_get_size (buffer) != pool->priv->size))
goto discard; goto size_changed;
/* all memory should be exclusive to this buffer (and thus be writable) */ /* all memory should be exclusive to this buffer (and thus be writable) */
if (!gst_buffer_is_all_memory_writable (buffer)) if (G_UNLIKELY (!gst_buffer_is_all_memory_writable (buffer)))
goto discard; goto not_writable;
/* keep it around in our queue */ /* keep it around in our queue */
gst_atomic_queue_push (pool->priv->queue, buffer); gst_atomic_queue_push (pool->priv->queue, buffer);
@ -1246,6 +1246,25 @@ default_release_buffer (GstBufferPool * pool, GstBuffer * buffer)
return; return;
memory_tagged:
{
GST_CAT_DEBUG_OBJECT (GST_CAT_PERFORMANCE, pool,
"discarding buffer %p: memory tag set", buffer);
goto discard;
}
size_changed:
{
GST_CAT_DEBUG_OBJECT (GST_CAT_PERFORMANCE, pool,
"discarding buffer %p: size %" G_GSIZE_FORMAT " != %u",
buffer, gst_buffer_get_size (buffer), pool->priv->size);
goto discard;
}
not_writable:
{
GST_CAT_DEBUG_OBJECT (GST_CAT_PERFORMANCE, pool,
"discarding buffer %p: memory not writable", buffer);
goto discard;
}
discard: discard:
{ {
do_free_buffer (pool, buffer); do_free_buffer (pool, buffer);